Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 851693003: Move select_favicon_frames_unittest.cc to favicon_base (Closed)

Created:
5 years, 11 months ago by sdefresne
Modified:
5 years, 11 months ago
Reviewers:
jif, jif-google, sky, blundell
CC:
browser-components-watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@history-top-sites-notifications
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move select_favicon_frames_unittest.cc to favicon_base Move select_favicon_frames_unittest.cc into the favicon_base with the code that it is testing. Add the unit_test to the components_unittests, including when using gn build system. BUG=359513 Committed: https://crrev.com/f900329e4f25bbab1be0514080d14fc500433018 Cr-Commit-Position: refs/heads/master@{#311437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -328 lines) Patch
D chrome/browser/history/select_favicon_frames_unittest.cc View 1 chunk +0 lines, -327 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 3 chunks +5 lines, -1 line 0 comments Download
M components/favicon_base/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M components/favicon_base/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + components/favicon_base/select_favicon_frames_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sdefresne
jif: please take a look sky: as OWNERS of //components/favicon_base blundell: as OWNERS of //components
5 years, 11 months ago (2015-01-13 15:43:13 UTC) #2
jif-google
lgtm
5 years, 11 months ago (2015-01-13 16:34:32 UTC) #4
jif
lgtm
5 years, 11 months ago (2015-01-13 16:35:00 UTC) #5
blundell
//components/BUILD.gn LGTM
5 years, 11 months ago (2015-01-13 16:51:07 UTC) #6
sky
LGTM
5 years, 11 months ago (2015-01-13 18:40:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851693003/1
5 years, 11 months ago (2015-01-14 09:13:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 09:49:43 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 09:50:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f900329e4f25bbab1be0514080d14fc500433018
Cr-Commit-Position: refs/heads/master@{#311437}

Powered by Google App Engine
This is Rietveld 408576698