Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 851563003: Revert of Oilpan: Query stack frame register instead of manual bookkeeping (Closed)

Created:
5 years, 11 months ago by kouhei (in TOK)
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Query stack frame register instead of manual bookkeeping (patchset #8 id:130001 of https://codereview.chromium.org/818253005/) Reason for revert: Maybe causing debug build asserts Original issue's description: > Oilpan: Query stack frame register instead of manual bookkeeping > > This CL introduce new class StackFrameDepth to keep track of > current stack frame depth. > On supported ABI/compiler, StackFrameDepth queries current > stack frame base register (e.g. %rbp on X86_64), skipping manual > bookkeeping. > > This improves Oilpan marking time by 17% on > BlinkGC.stress-large-SVGLengthList.html. > > TEST=PerformanceTests/BlinkGC/stress-large-SVGLengthList.html > BUG=420515 > R=haraken@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188108 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOTRY=true BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -107 lines) Patch
M Source/platform/heap/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/heap/InlinedGlobalMarkingVisitor.h View 1 chunk +2 lines, -0 lines 0 comments Download
D Source/platform/heap/StackFrameDepth.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/platform/heap/StackFrameDepth.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/platform/heap/Visitor.h View 4 chunks +14 lines, -16 lines 0 comments Download
M Source/platform/heap/Visitor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/blink_heap.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kouhei (in TOK)
Created Revert of Oilpan: Query stack frame register instead of manual bookkeeping
5 years, 11 months ago (2015-01-13 01:18:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851563003/1
5 years, 11 months ago (2015-01-13 01:18:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188260
5 years, 11 months ago (2015-01-13 01:19:27 UTC) #3
haraken
LGTM, thanks for reverting this. Let's stabilize our trees first.
5 years, 11 months ago (2015-01-13 01:31:18 UTC) #4
sof
5 years, 11 months ago (2015-01-13 06:06:19 UTC) #5
Message was sent while issue was closed.
Always use an explicit marking stack when processing the weak callbacks to a
fixed point, might be worth considering.

Powered by Google App Engine
This is Rietveld 408576698