Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Unified Diff: chrome/browser/browsing_data/browsing_data_appcache_helper.cc

Issue 851553003: Remove bad use of CancelableCallback from BrowingDataAppCacheHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: inline Bind Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_appcache_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_appcache_helper.cc
diff --git a/chrome/browser/browsing_data/browsing_data_appcache_helper.cc b/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
index b11e486353a4390f7066b90d78c7df38337888a6..b7c330e6400277df2caa9fcc99a345de286ecee0 100644
--- a/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
+++ b/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
@@ -10,6 +10,7 @@
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/storage_partition.h"
+#include "net/base/completion_callback.h"
using content::BrowserContext;
using content::BrowserThread;
@@ -35,11 +36,9 @@ void BrowsingDataAppCacheHelper::StartFetching(const base::Closure& callback) {
}
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- appcache_info_callback_.Reset(
- base::Bind(&BrowsingDataAppCacheHelper::OnFetchComplete,
- base::Unretained(this)));
- appcache_service_->GetAllAppCacheInfo(info_collection_.get(),
- appcache_info_callback_.callback());
+ appcache_service_->GetAllAppCacheInfo(
+ info_collection_.get(),
+ base::Bind(&BrowsingDataAppCacheHelper::OnFetchComplete, this));
}
void BrowsingDataAppCacheHelper::DeleteAppCacheGroup(
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_appcache_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698