Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: base/test/expectations/expectation.cc

Issue 851503003: Update from https://crrev.com/311076 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/launch_posix.cc ('k') | base/test/test_file_util_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/expectations/expectation.cc
diff --git a/base/test/expectations/expectation.cc b/base/test/expectations/expectation.cc
index 9b06e282f27a2e56fa7f6749b9fd3635d0669d22..30817791dd2da22d4f612c0959cd0864ae3f9a6c 100644
--- a/base/test/expectations/expectation.cc
+++ b/base/test/expectations/expectation.cc
@@ -38,7 +38,7 @@ static bool IsValidPlatform(const Platform* platform) {
const std::string& variant = platform->variant;
if (name == "Win") {
- if (variant != "" &&
+ if (!variant.empty() &&
variant != "XP" &&
variant != "Vista" &&
variant != "7" &&
@@ -46,7 +46,7 @@ static bool IsValidPlatform(const Platform* platform) {
return false;
}
} else if (name == "Mac") {
- if (variant != "" &&
+ if (!variant.empty() &&
variant != "10.6" &&
variant != "10.7" &&
variant != "10.8" &&
@@ -55,7 +55,7 @@ static bool IsValidPlatform(const Platform* platform) {
return false;
}
} else if (name == "Linux") {
- if (variant != "" &&
+ if (!variant.empty() &&
variant != "32" &&
variant != "64") {
return false;
« no previous file with comments | « base/process/launch_posix.cc ('k') | base/test/test_file_util_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698