Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: net/quic/quic_config_test.cc

Issue 851503003: Update from https://crrev.com/311076 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_config.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_config_test.cc
diff --git a/net/quic/quic_config_test.cc b/net/quic/quic_config_test.cc
index 1bdc4564e81eee2e4be8955d2d67e98e3f07c4ca..8e2b34bf8ff19ce2b6b03e5acb80a6353100ec6a 100644
--- a/net/quic/quic_config_test.cc
+++ b/net/quic/quic_config_test.cc
@@ -26,8 +26,6 @@ class QuicConfigTest : public ::testing::Test {
};
TEST_F(QuicConfigTest, ToHandshakeMessage) {
- config_.SetInitialFlowControlWindowToSend(
- kInitialSessionFlowControlWindowForTest);
config_.SetInitialStreamFlowControlWindowToSend(
kInitialStreamFlowControlWindowForTest);
config_.SetInitialSessionFlowControlWindowToSend(
@@ -48,10 +46,6 @@ TEST_F(QuicConfigTest, ToHandshakeMessage) {
EXPECT_EQ(QUIC_NO_ERROR, error);
EXPECT_EQ(4u, value);
- error = msg.GetUint32(kIFCW, &value);
- EXPECT_EQ(QUIC_NO_ERROR, error);
- EXPECT_EQ(kInitialSessionFlowControlWindowForTest, value);
-
error = msg.GetUint32(kSFCW, &value);
EXPECT_EQ(QUIC_NO_ERROR, error);
EXPECT_EQ(kInitialStreamFlowControlWindowForTest, value);
@@ -82,8 +76,6 @@ TEST_F(QuicConfigTest, ProcessClientHello) {
client_config.SetMaxStreamsPerConnection(
2 * kDefaultMaxStreamsPerConnection, kDefaultMaxStreamsPerConnection);
client_config.SetInitialRoundTripTimeUsToSend(10 * kNumMicrosPerMilli);
- client_config.SetInitialFlowControlWindowToSend(
- 2 * kInitialSessionFlowControlWindowForTest);
client_config.SetInitialStreamFlowControlWindowToSend(
2 * kInitialStreamFlowControlWindowForTest);
client_config.SetInitialSessionFlowControlWindowToSend(
@@ -111,8 +103,6 @@ TEST_F(QuicConfigTest, ProcessClientHello) {
EXPECT_EQ(2u, config_.ReceivedConnectionOptions().size());
EXPECT_EQ(config_.ReceivedConnectionOptions()[0], kTBBR);
EXPECT_EQ(config_.ReceivedConnectionOptions()[1], kFHDR);
- EXPECT_EQ(config_.ReceivedInitialFlowControlWindowBytes(),
- 2 * kInitialSessionFlowControlWindowForTest);
EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(),
2 * kInitialStreamFlowControlWindowForTest);
EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(),
@@ -133,8 +123,6 @@ TEST_F(QuicConfigTest, ProcessServerHello) {
kDefaultMaxStreamsPerConnection / 2,
kDefaultMaxStreamsPerConnection / 2);
server_config.SetInitialRoundTripTimeUsToSend(10 * kNumMicrosPerMilli);
- server_config.SetInitialFlowControlWindowToSend(
- 2 * kInitialSessionFlowControlWindowForTest);
server_config.SetInitialStreamFlowControlWindowToSend(
2 * kInitialStreamFlowControlWindowForTest);
server_config.SetInitialSessionFlowControlWindowToSend(
@@ -153,8 +141,6 @@ TEST_F(QuicConfigTest, ProcessServerHello) {
EXPECT_EQ(kDefaultMaxStreamsPerConnection / 2,
config_.MaxStreamsPerConnection());
EXPECT_EQ(10 * kNumMicrosPerMilli, config_.ReceivedInitialRoundTripTimeUs());
- EXPECT_EQ(config_.ReceivedInitialFlowControlWindowBytes(),
- 2 * kInitialSessionFlowControlWindowForTest);
EXPECT_EQ(config_.ReceivedInitialStreamFlowControlWindowBytes(),
2 * kInitialStreamFlowControlWindowForTest);
EXPECT_EQ(config_.ReceivedInitialSessionFlowControlWindowBytes(),
@@ -179,8 +165,6 @@ TEST_F(QuicConfigTest, MissingOptionalValuesInCHLO) {
config_.ProcessPeerHello(msg, CLIENT, &error_details);
EXPECT_EQ(QUIC_NO_ERROR, error);
EXPECT_TRUE(config_.negotiated());
-
- EXPECT_FALSE(config_.HasReceivedInitialFlowControlWindowBytes());
}
TEST_F(QuicConfigTest, MissingOptionalValuesInSHLO) {
@@ -197,8 +181,6 @@ TEST_F(QuicConfigTest, MissingOptionalValuesInSHLO) {
config_.ProcessPeerHello(msg, SERVER, &error_details);
EXPECT_EQ(QUIC_NO_ERROR, error);
EXPECT_TRUE(config_.negotiated());
-
- EXPECT_FALSE(config_.HasReceivedInitialFlowControlWindowBytes());
}
TEST_F(QuicConfigTest, MissingValueInCHLO) {
@@ -272,11 +254,11 @@ TEST_F(QuicConfigTest, InvalidFlowControlWindow) {
// peer: the receive window must be at least the default of 16 Kb.
QuicConfig config;
const uint64 kInvalidWindow = kMinimumFlowControlSendWindow - 1;
- EXPECT_DFATAL(config.SetInitialFlowControlWindowToSend(kInvalidWindow),
- "Initial flow control receive window");
+ EXPECT_DFATAL(config.SetInitialStreamFlowControlWindowToSend(kInvalidWindow),
+ "Initial stream flow control receive window");
EXPECT_EQ(kMinimumFlowControlSendWindow,
- config.GetInitialFlowControlWindowToSend());
+ config.GetInitialStreamFlowControlWindowToSend());
}
} // namespace
« no previous file with comments | « net/quic/quic_config.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698