Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: net/base/sdch_observer.h

Issue 851503003: Update from https://crrev.com/311076 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/sdch_manager_unittest.cc ('k') | net/base/sdch_problem_code_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/sdch_observer.h
diff --git a/net/base/sdch_observer.h b/net/base/sdch_observer.h
index 2c5987d8698cb86f6206454ab0ff593854f437e7..61603b067ee3998f4493e94bc936f5871a2d129c 100644
--- a/net/base/sdch_observer.h
+++ b/net/base/sdch_observer.h
@@ -5,6 +5,9 @@
#ifndef NET_BASE_SDCH_OBSERVER_H_
#define NET_BASE_SDCH_OBSERVER_H_
+#include <iosfwd>
+#include <string>
+
#include "net/base/net_export.h"
class GURL;
@@ -19,7 +22,24 @@ class NET_EXPORT SdchObserver {
public:
virtual ~SdchObserver();
- // Notification that SDCH has seen a "Get-Dictionary" header.
+ // TODO(rdsmith): Add Added/Removed signals. These are only needed if
+ // we end up with an implementation in which more than one observer
+ // generates Add/Removed events; otherwise, tracking can be done internally.
+
+ // TODO(rdsmith): Add signal that an Avail-Dictionary header was generated.
+ // Should be added if/when an observer wants to use it to fine-tune
+ // dictionary deprecation (e.g. if Avail-Dictionary is generated and
+ // the remote *doesn't* use it, that should deprecate the dictionary faster)
+
+ // A SDCH encoded response was received and the specified dictionary
+ // was used to decode it. This notification only occurs for successful
+ // decodes.
+ // TODO(rdsmith): Should this notification indicate how much
+ // compression the dictionary provided?
+ virtual void OnDictionaryUsed(SdchManager* manager,
+ const std::string& server_hash) = 0;
+
+ // A "Get-Dictionary" header has been seen.
virtual void OnGetDictionary(SdchManager* manager,
const GURL& request_url,
const GURL& dictionary_url) = 0;
« no previous file with comments | « net/base/sdch_manager_unittest.cc ('k') | net/base/sdch_problem_code_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698