| OLD | NEW |
|---|
| (Empty) | |
| 1 Some network label caveats |
| 2 * Cr-UI-Browser-Downloads: Despite the name, this covers all issues related to |
| 3 downloading a file except saving entire pages (Which is Cr-Blink-SavePage), |
| 4 not just UI issues. Most downloads bugs will have the word "download" or |
| 5 "save as" in the description. Issues with the HTTP server for the Chrome |
| 6 binaries are not downloads bugs. |
| 7 * Cr-UI-Browser-SafeBrowsing: Bugs that have to do with the process by which a |
| 8 URL or file is determined to be dangerous based on our databases, or the |
| 9 resulting interstitials. Determination of danger based purely on |
| 10 content-type or file extension belongs in Cr-UI-Browser-Downloads, not |
| 11 SafeBrowsing. |
| 12 * Cr-Internals-Network-SSL: This includes issues that should be also tagged as |
| 13 Cr-Security-UX (certificate error pages or other security interstitials, |
| 14 omnibox indicators that a page is secure), and more general SSL issues. If |
| 15 you see requests that die in the SSL negotiation phase, in particular, this |
| 16 is often the correct label. |
| 17 * Cr-Internals-Network-DataProxy: Flywheel / the Data Reduction Proxy. Issues |
| 18 require "Reduce Data Usage" be turned on. Proxy url is |
| 19 https://proxy.googlezip.net:443, with compress.googlezip.net:80 as a |
| 20 fallback. Currently Android and iOS only. |
| 21 * Cr-Internals-Network-Cache: The cache is the layer that handles most range |
| 22 request logic (Though range requests may also be issued by the PDF plugin, |
| 23 XHRs, or other components). |
| 24 * Cr-Internals-Network-SPDY: Covers HTTP2 as well. |
| 25 * Cr-Internals-Network-HTTP: Typically not used. Unclear what it covers, and |
| 26 there's no specific HTTP owner. |
| 27 * Cr-Internals-Network-Logging: Covers about:net-internals, about:net-export as |
| 28 well as the what's sent to the NetLog. |
| 29 * Cr-Internals-Network-Connectivity: Issues related to switching between |
| 30 networks, ERR_NETWORK_CHANGED, Chrome thinking it's online when it's not / |
| 31 navigator.onLine inaccuracies, etc. |
| 32 * Cr-Internals-Network-Filters: Covers SDCH and gzip issues. |
| 33 ERR_CONTENT_DECODING_FAILED indicates a problem at this layer, and bugs here |
| 34 can also cause response body corruption. |
| 35 |
| 36 |
| 37 Common non-network label reference. Bugs in these areas often receive the |
| 38 Cr-Internals-Network label, though they fall largely outside the purview of the |
| 39 network stack team: |
| 40 * Cr-Blink-Forms: Issues submitting forms, forms having weird data, forms |
| 41 sending the wrong method, etc. |
| 42 * Cr-Blink-Loader: Cross origin issues are sometimes loader related. Blink |
| 43 also has an in-memory cache, and when it's used, requests don't appear in |
| 44 about:net-internals. Requests for the same URL are also often merged there |
| 45 as well. This does *not* cover issues with content/browser/loader/ files. |
| 46 * Cr-Blink-ServiceWorker |
| 47 * Cr-Blink-Storage-AppCache |
| 48 * Cr-Blink-WebSockets |
| 49 * Cr-Blink-XHR: Generic issues with sync/async XHR requests - missing request |
| 50 or response headers, multiple headers, etc. These will often run into |
| 51 issues in certain corner cases (Cross origin / CORS, proxy, whatever). |
| 52 Attach all labels that seem appropriate. |
| 53 * Cr-Services-Sync: Sharing data/tabs/history/passwords/etc between machines |
| 54 not working. |
| 55 * Cr-Services-Chromoting |
| 56 * Cr-Platform-Extensions: Issues extensions loading / not loading / hanging. |
| 57 * Cr-Platform-Extensions-API: Issues with network related extension APIs should |
| 58 have this label. chrome.webRequest is the big one, I believe, but there are |
| 59 others. |
| 60 * Cr-Internals-Plugins-Pepper[-SDK] |
| 61 * Cr-UI-Browser-Omnibox: Basically any issue with the omnibox. URLs being |
| 62 treated as search queries rather than navigations, dropdown results being |
| 63 weird, not handling certain unicode characters, etc. If the issue is new |
| 64 TLDs not being recognized by the omnibox, that's due to Chrome's TLD list |
| 65 being out of date, and not an omnibox issue. Such TLD issues should be |
| 66 duped against http://crbug.com/37436. |
| 67 * Cr-Internals-Media-Network: Issues related to media. These often run into |
| 68 the 6 requests per hostname issue, and also have fun interactions with the |
| 69 cache, particularly in the range request case. |
| 70 * Cr-Internals-Plugins-PDF: Issues loading pdf files. These are often related |
| 71 to range requests, which also have some logic at the Internals-Network-Cache |
| 72 layer. |
| 73 * Cr-UI-Browser-Navigation |
| 74 * Cr-UI-Browser-History: Issues which only appear with forward/back navigation. |
| 75 * Cr-OS-Systems-Network / Cr-OS-Systems-Mobile / Cr-OS-Systems-Bluetooth: These |
| 76 should be used for issues with ChromeOS's platform network code, and not |
| 77 net/ issues on ChromeOS. |
| 78 * Cr-Blink-SecurityFeature: CORS / Cross origin issues. Main frame |
| 79 cross-origin navigation issues are often actually Cr-UI-Browser-Navigation |
| 80 issues. |
| 81 * Cr-Privacy: Privacy related bug (History, cookies discoverable by an entity |
| 82 that shouldn't be able to do so, incognito state being saved in memory or on |
| 83 disk beyond the lifetime of incognito tabs, etc). Generally used in |
| 84 conjunction with other labels. |
| 85 * Type-Bug-Security: Security related bug (Allows for code execution from |
| 86 remote site, allows crossing security boundaries, unchecked array bounds, |
| 87 etc). |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 851503003:
Update from https://crrev.com/311076 (Closed)
Base URL: git@github.com:domokit/mojo.git@master