Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: base/test/expectations/expectation.cc

Issue 851503003: Update from https://crrev.com/311076 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/process/launch_posix.cc ('k') | base/test/test_file_util_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/expectations/expectation.h" 5 #include "base/test/expectations/expectation.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include "base/win/windows_version.h" 10 #include "base/win/windows_version.h"
(...skipping 20 matching lines...) Expand all
31 return false; 31 return false;
32 32
33 return true; 33 return true;
34 } 34 }
35 35
36 static bool IsValidPlatform(const Platform* platform) { 36 static bool IsValidPlatform(const Platform* platform) {
37 const std::string& name = platform->name; 37 const std::string& name = platform->name;
38 const std::string& variant = platform->variant; 38 const std::string& variant = platform->variant;
39 39
40 if (name == "Win") { 40 if (name == "Win") {
41 if (variant != "" && 41 if (!variant.empty() &&
42 variant != "XP" && 42 variant != "XP" &&
43 variant != "Vista" && 43 variant != "Vista" &&
44 variant != "7" && 44 variant != "7" &&
45 variant != "8") { 45 variant != "8") {
46 return false; 46 return false;
47 } 47 }
48 } else if (name == "Mac") { 48 } else if (name == "Mac") {
49 if (variant != "" && 49 if (!variant.empty() &&
50 variant != "10.6" && 50 variant != "10.6" &&
51 variant != "10.7" && 51 variant != "10.7" &&
52 variant != "10.8" && 52 variant != "10.8" &&
53 variant != "10.9" && 53 variant != "10.9" &&
54 variant != "10.10") { 54 variant != "10.10") {
55 return false; 55 return false;
56 } 56 }
57 } else if (name == "Linux") { 57 } else if (name == "Linux") {
58 if (variant != "" && 58 if (!variant.empty() &&
59 variant != "32" && 59 variant != "32" &&
60 variant != "64") { 60 variant != "64") {
61 return false; 61 return false;
62 } 62 }
63 } else if (name == "ChromeOS") { 63 } else if (name == "ChromeOS") {
64 // TODO(rsesek): Figure out what ChromeOS needs. 64 // TODO(rsesek): Figure out what ChromeOS needs.
65 } else if (name == "iOS") { 65 } else if (name == "iOS") {
66 // TODO(rsesek): Figure out what iOS needs. Probably Device and Simulator. 66 // TODO(rsesek): Figure out what iOS needs. Probably Device and Simulator.
67 } else if (name == "Android") { 67 } else if (name == "Android") {
68 // TODO(rsesek): Figure out what Android needs. 68 // TODO(rsesek): Figure out what Android needs.
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 } 152 }
153 153
154 Expectation::Expectation() 154 Expectation::Expectation()
155 : configuration(CONFIGURATION_UNSPECIFIED), 155 : configuration(CONFIGURATION_UNSPECIFIED),
156 result(RESULT_PASS) { 156 result(RESULT_PASS) {
157 } 157 }
158 158
159 Expectation::~Expectation() {} 159 Expectation::~Expectation() {}
160 160
161 } // namespace test_expectations 161 } // namespace test_expectations
OLDNEW
« no previous file with comments | « base/process/launch_posix.cc ('k') | base/test/test_file_util_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698