add previously focused node to WebClient::focusedNodeChanged

public/web/WebViewClient.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 168 matching lines @@
 
     // Called to determine if drag-n-drop operations may initiate a page
     // navigation.
     virtual bool acceptsLoadDrops() { return true; }
 
     // Take focus away from the WebView by focusing an adjacent UI element
     // in the containing window.
     virtual void focusNext() { }
     virtual void focusPrevious() { }
 
-    // Called when a new node gets focused.
+    // TODO(estade): remove this function.

[Mike West, 2015/01/19 08:52:16]

Totally tiny nit: We use FIXME in Blink.

[Evan Stade, 2015/01/20 22:23:54]

Done.

     virtual void focusedNodeChanged(const WebNode&) { }
+    // Called when a new node gets focused. First argument is the previously focused node, the
+    // second is the newly focused node. Either can be null.
+    virtual void focusedNodeChanged(const WebNode&, const WebNode&) { }

[dmazzoni, 2015/01/20 07:31:52]

Nit: Blink leaves out argument names in header files when they're obvious or
redundant, but not when it's helpful to distinguish between two arguments. I
think these should be named.

[Evan Stade, 2015/01/20 22:23:54]

Done.

 
     // Indicates two things:
     //   1) This view may have a new layout now.
     //   2) Calling layout() is a no-op.
     // After calling WebWidget::layout(), expect to get this notification
     // unless the view did not need a layout.
     virtual void didUpdateLayout() { }
 
     // Return true to swallow the input event if the embedder will start a disambiguation popup
     virtual bool didTapMultipleTargets(const WebSize& pinchViewportOffset, const WebRect& touchRect, const WebVector<WebRect>& targetRects) { return false; }
@@ skipping 92 matching lines @@
     // Informs the browser that the draggable regions have been updated.
     virtual void draggableRegionsChanged() { }
 
 protected:
     ~WebViewClient() { }
 };
 
 } // namespace blink
 
 #endif