Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 851333005: Revert of Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 int routing_id) { 112 int routing_id) {
113 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 113 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
114 RoutingIDFrameMap* frames = g_routing_id_frame_map.Pointer(); 114 RoutingIDFrameMap* frames = g_routing_id_frame_map.Pointer();
115 RoutingIDFrameMap::iterator it = frames->find( 115 RoutingIDFrameMap::iterator it = frames->find(
116 RenderFrameHostID(process_id, routing_id)); 116 RenderFrameHostID(process_id, routing_id));
117 return it == frames->end() ? NULL : it->second; 117 return it == frames->end() ? NULL : it->second;
118 } 118 }
119 119
120 RenderFrameHostImpl::RenderFrameHostImpl(RenderViewHostImpl* render_view_host, 120 RenderFrameHostImpl::RenderFrameHostImpl(RenderViewHostImpl* render_view_host,
121 RenderFrameHostDelegate* delegate, 121 RenderFrameHostDelegate* delegate,
122 RenderWidgetHostDelegate* rwh_delegate,
123 FrameTree* frame_tree, 122 FrameTree* frame_tree,
124 FrameTreeNode* frame_tree_node, 123 FrameTreeNode* frame_tree_node,
125 int routing_id, 124 int routing_id,
126 int flags) 125 int flags)
127 : render_view_host_(render_view_host), 126 : render_view_host_(render_view_host),
128 delegate_(delegate), 127 delegate_(delegate),
129 cross_process_frame_connector_(NULL), 128 cross_process_frame_connector_(NULL),
130 render_frame_proxy_host_(NULL), 129 render_frame_proxy_host_(NULL),
131 frame_tree_(frame_tree), 130 frame_tree_(frame_tree),
132 frame_tree_node_(frame_tree_node), 131 frame_tree_node_(frame_tree_node),
133 routing_id_(routing_id), 132 routing_id_(routing_id),
134 render_frame_created_(false), 133 render_frame_created_(false),
135 navigations_suspended_(false), 134 navigations_suspended_(false),
136 is_waiting_for_beforeunload_ack_(false), 135 is_waiting_for_beforeunload_ack_(false),
137 unload_ack_is_for_cross_site_transition_(false), 136 unload_ack_is_for_cross_site_transition_(false),
138 accessibility_reset_token_(0), 137 accessibility_reset_token_(0),
139 accessibility_reset_count_(0), 138 accessibility_reset_count_(0),
140 no_create_browser_accessibility_manager_for_testing_(false), 139 no_create_browser_accessibility_manager_for_testing_(false),
141 weak_ptr_factory_(this) { 140 weak_ptr_factory_(this) {
142 bool is_swapped_out = !!(flags & CREATE_RF_SWAPPED_OUT); 141 bool is_swapped_out = !!(flags & CREATE_RF_SWAPPED_OUT);
143 bool hidden = !!(flags & CREATE_RF_HIDDEN);
144 frame_tree_->RegisterRenderFrameHost(this); 142 frame_tree_->RegisterRenderFrameHost(this);
145 GetProcess()->AddRoute(routing_id_, this); 143 GetProcess()->AddRoute(routing_id_, this);
146 g_routing_id_frame_map.Get().insert(std::make_pair( 144 g_routing_id_frame_map.Get().insert(std::make_pair(
147 RenderFrameHostID(GetProcess()->GetID(), routing_id_), 145 RenderFrameHostID(GetProcess()->GetID(), routing_id_),
148 this)); 146 this));
149 147
150 if (is_swapped_out) { 148 if (is_swapped_out) {
151 rfh_state_ = STATE_SWAPPED_OUT; 149 rfh_state_ = STATE_SWAPPED_OUT;
152 } else { 150 } else {
153 rfh_state_ = STATE_DEFAULT; 151 rfh_state_ = STATE_DEFAULT;
154 GetSiteInstance()->increment_active_frame_count(); 152 GetSiteInstance()->increment_active_frame_count();
155 } 153 }
156 154
157 SetUpMojoIfNeeded(); 155 SetUpMojoIfNeeded();
158 swapout_event_monitor_timeout_.reset(new TimeoutMonitor(base::Bind( 156 swapout_event_monitor_timeout_.reset(new TimeoutMonitor(base::Bind(
159 &RenderFrameHostImpl::OnSwappedOut, weak_ptr_factory_.GetWeakPtr()))); 157 &RenderFrameHostImpl::OnSwappedOut, weak_ptr_factory_.GetWeakPtr())));
160
161 if (flags & CREATE_RF_NEEDS_RENDER_WIDGET_HOST) {
162 render_widget_host_.reset(new RenderWidgetHostImpl(
163 rwh_delegate, GetProcess(), MSG_ROUTING_NONE, hidden));
164 render_widget_host_->set_owned_by_render_frame_host(true);
165 }
166 } 158 }
167 159
168 RenderFrameHostImpl::~RenderFrameHostImpl() { 160 RenderFrameHostImpl::~RenderFrameHostImpl() {
169 GetProcess()->RemoveRoute(routing_id_); 161 GetProcess()->RemoveRoute(routing_id_);
170 g_routing_id_frame_map.Get().erase( 162 g_routing_id_frame_map.Get().erase(
171 RenderFrameHostID(GetProcess()->GetID(), routing_id_)); 163 RenderFrameHostID(GetProcess()->GetID(), routing_id_));
172 164
173 if (delegate_) 165 if (delegate_)
174 delegate_->RenderFrameDeleted(this); 166 delegate_->RenderFrameDeleted(this);
175 167
176 FrameAccessibility::GetInstance()->OnRenderFrameHostDestroyed(this); 168 FrameAccessibility::GetInstance()->OnRenderFrameHostDestroyed(this);
177 169
178 // If this was swapped out, it already decremented the active frame count of 170 // If this was swapped out, it already decremented the active frame count of
179 // the SiteInstance it belongs to. 171 // the SiteInstance it belongs to.
180 if (IsRFHStateActive(rfh_state_)) 172 if (IsRFHStateActive(rfh_state_))
181 GetSiteInstance()->decrement_active_frame_count(); 173 GetSiteInstance()->decrement_active_frame_count();
182 174
183 // Notify the FrameTree that this RFH is going away, allowing it to shut down 175 // Notify the FrameTree that this RFH is going away, allowing it to shut down
184 // the corresponding RenderViewHost if it is no longer needed. 176 // the corresponding RenderViewHost if it is no longer needed.
185 frame_tree_->UnregisterRenderFrameHost(this); 177 frame_tree_->UnregisterRenderFrameHost(this);
186 178
187 // NULL out the swapout timer; in crash dumps this member will be null only if 179 // NULL out the swapout timer; in crash dumps this member will be null only if
188 // the dtor has run. 180 // the dtor has run.
189 swapout_event_monitor_timeout_.reset(); 181 swapout_event_monitor_timeout_.reset();
190
191 if (render_widget_host_)
192 render_widget_host_->Cleanup();
193 } 182 }
194 183
195 int RenderFrameHostImpl::GetRoutingID() { 184 int RenderFrameHostImpl::GetRoutingID() {
196 return routing_id_; 185 return routing_id_;
197 } 186 }
198 187
199 SiteInstanceImpl* RenderFrameHostImpl::GetSiteInstance() { 188 SiteInstanceImpl* RenderFrameHostImpl::GetSiteInstance() {
200 return render_view_host_->GetSiteInstance(); 189 return render_view_host_->GetSiteInstance();
201 } 190 }
202 191
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 507
519 // The process may (if we're sharing a process with another host that already 508 // The process may (if we're sharing a process with another host that already
520 // initialized it) or may not (we have our own process or the old process 509 // initialized it) or may not (we have our own process or the old process
521 // crashed) have been initialized. Calling Init multiple times will be 510 // crashed) have been initialized. Calling Init multiple times will be
522 // ignored, so this is safe. 511 // ignored, so this is safe.
523 if (!GetProcess()->Init()) 512 if (!GetProcess()->Init())
524 return false; 513 return false;
525 514
526 DCHECK(GetProcess()->HasConnection()); 515 DCHECK(GetProcess()->HasConnection());
527 516
528 FrameMsg_NewFrame_WidgetParams widget_params;
529 if (render_widget_host_) {
530 widget_params.routing_id = render_widget_host_->GetRoutingID();
531 widget_params.surface_id = render_widget_host_->surface_id();
532 widget_params.hidden = render_widget_host_->is_hidden();
533 } else {
534 // MSG_ROUTING_NONE will prevent a new RenderWidget from being created in
535 // the renderer process.
536 widget_params.routing_id = MSG_ROUTING_NONE;
537 widget_params.surface_id = 0;
538 widget_params.hidden = true;
539 }
540
541 Send(new FrameMsg_NewFrame(routing_id_, parent_routing_id, proxy_routing_id, 517 Send(new FrameMsg_NewFrame(routing_id_, parent_routing_id, proxy_routing_id,
542 frame_tree_node()->current_replication_state(), 518 frame_tree_node()->current_replication_state()));
543 widget_params));
544
545 // The RenderWidgetHost takes ownership of its view. It is tied to the
546 // lifetime of the current RenderProcessHost for this RenderFrameHost.
547 if (render_widget_host_) {
548 RenderWidgetHostView* rwhv =
549 new RenderWidgetHostViewChildFrame(render_widget_host_.get());
550 rwhv->Hide();
551 }
552 519
553 // The renderer now has a RenderFrame for this RenderFrameHost. Note that 520 // The renderer now has a RenderFrame for this RenderFrameHost. Note that
554 // this path is only used for out-of-process iframes. Main frame RenderFrames 521 // this path is only used for out-of-process iframes. Main frame RenderFrames
555 // are created with their RenderView, and same-site iframes are created at the 522 // are created with their RenderView, and same-site iframes are created at the
556 // time of OnCreateChildFrame. 523 // time of OnCreateChildFrame.
557 SetRenderFrameCreated(true); 524 set_render_frame_created(true);
558 525
559 return true; 526 return true;
560 } 527 }
561 528
562 bool RenderFrameHostImpl::IsRenderFrameLive() { 529 bool RenderFrameHostImpl::IsRenderFrameLive() {
563 // RenderFrames are created for main frames at the same time as RenderViews, 530 // RenderFrames are created for main frames at the same time as RenderViews,
564 // so we rely on IsRenderViewLive. For subframes, we keep track of each 531 // so we rely on IsRenderViewLive. For subframes, we keep track of each
565 // RenderFrame individually with render_frame_created_. 532 // RenderFrame individually with render_frame_created_.
566 bool is_live = !GetParent() ? 533 bool is_live = !GetParent() ?
567 render_view_host_->IsRenderViewLive() : 534 render_view_host_->IsRenderViewLive() :
568 GetProcess()->HasConnection() && render_frame_created_; 535 GetProcess()->HasConnection() && render_frame_created_;
569 536
570 // Sanity check: the RenderView should always be live if the RenderFrame is. 537 // Sanity check: the RenderView should always be live if the RenderFrame is.
571 DCHECK(!is_live || render_view_host_->IsRenderViewLive()); 538 DCHECK(!is_live || render_view_host_->IsRenderViewLive());
572 539
573 return is_live; 540 return is_live;
574 } 541 }
575 542
576 void RenderFrameHostImpl::SetRenderFrameCreated(bool created) {
577 render_frame_created_ = created;
578 if (created && render_widget_host_)
579 render_widget_host_->InitForFrame();
580 }
581
582 void RenderFrameHostImpl::Init() { 543 void RenderFrameHostImpl::Init() {
583 GetProcess()->ResumeRequestsForView(routing_id_); 544 GetProcess()->ResumeRequestsForView(routing_id_);
584 } 545 }
585 546
586 void RenderFrameHostImpl::OnAddMessageToConsole( 547 void RenderFrameHostImpl::OnAddMessageToConsole(
587 int32 level, 548 int32 level,
588 const base::string16& message, 549 const base::string16& message,
589 int32 line_no, 550 int32 line_no,
590 const base::string16& source_id) { 551 const base::string16& source_id) {
591 if (delegate_->AddMessageToConsole(level, message, line_no, source_id)) 552 if (delegate_->AddMessageToConsole(level, message, line_no, source_id))
(...skipping 21 matching lines...) Expand all
613 if (rfh_state_ != RenderFrameHostImpl::STATE_DEFAULT) 574 if (rfh_state_ != RenderFrameHostImpl::STATE_DEFAULT)
614 return; 575 return;
615 576
616 RenderFrameHostImpl* new_frame = frame_tree_->AddFrame( 577 RenderFrameHostImpl* new_frame = frame_tree_->AddFrame(
617 frame_tree_node_, GetProcess()->GetID(), new_routing_id, frame_name); 578 frame_tree_node_, GetProcess()->GetID(), new_routing_id, frame_name);
618 if (!new_frame) 579 if (!new_frame)
619 return; 580 return;
620 581
621 // We know that the RenderFrame has been created in this case, immediately 582 // We know that the RenderFrame has been created in this case, immediately
622 // after the CreateChildFrame IPC was sent. 583 // after the CreateChildFrame IPC was sent.
623 new_frame->SetRenderFrameCreated(true); 584 new_frame->set_render_frame_created(true);
624 585
625 new_frame->frame_tree_node()->set_sandbox_flags(sandbox_flags); 586 new_frame->frame_tree_node()->set_sandbox_flags(sandbox_flags);
626 587
627 if (delegate_) 588 if (delegate_)
628 delegate_->RenderFrameCreated(new_frame); 589 delegate_->RenderFrameCreated(new_frame);
629 } 590 }
630 591
631 void RenderFrameHostImpl::OnDetach() { 592 void RenderFrameHostImpl::OnDetach() {
632 frame_tree_->RemoveFrame(frame_tree_node_); 593 frame_tree_->RemoveFrame(frame_tree_node_);
633 } 594 }
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 725
765 void RenderFrameHostImpl::OnDidDropNavigation() { 726 void RenderFrameHostImpl::OnDidDropNavigation() {
766 // At the end of Navigate(), the delegate's DidStartLoading is called to force 727 // At the end of Navigate(), the delegate's DidStartLoading is called to force
767 // the spinner to start, even if the renderer didn't yet begin the load. If it 728 // the spinner to start, even if the renderer didn't yet begin the load. If it
768 // turns out that the renderer dropped the navigation, we need to turn off the 729 // turns out that the renderer dropped the navigation, we need to turn off the
769 // spinner. 730 // spinner.
770 delegate_->DidStopLoading(this); 731 delegate_->DidStopLoading(this);
771 } 732 }
772 733
773 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() { 734 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() {
774 if (render_widget_host_) 735 return static_cast<RenderWidgetHostImpl*>(render_view_host_);
775 return render_widget_host_.get();
776
777 // TODO(kenrb): When RenderViewHost no longer inherits RenderWidgetHost,
778 // we can remove this fallback. Currently it is only used for the main
779 // frame.
780 if (!GetParent())
781 return static_cast<RenderWidgetHostImpl*>(render_view_host_);
782
783 return nullptr;
784 }
785
786 RenderWidgetHostView* RenderFrameHostImpl::GetView() {
787 RenderFrameHostImpl* frame = this;
788 while (frame) {
789 if (frame->render_widget_host_)
790 return frame->render_widget_host_->GetView();
791 frame = static_cast<RenderFrameHostImpl*>(frame->GetParent());
792 }
793
794 return render_view_host_->GetView();
795 } 736 }
796 737
797 int RenderFrameHostImpl::GetEnabledBindings() { 738 int RenderFrameHostImpl::GetEnabledBindings() {
798 return render_view_host_->GetEnabledBindings(); 739 return render_view_host_->GetEnabledBindings();
799 } 740 }
800 741
801 void RenderFrameHostImpl::OnCrossSiteResponse( 742 void RenderFrameHostImpl::OnCrossSiteResponse(
802 const GlobalRequestID& global_request_id, 743 const GlobalRequestID& global_request_id,
803 scoped_ptr<CrossSiteTransferringRequest> cross_site_transferring_request, 744 scoped_ptr<CrossSiteTransferringRequest> cross_site_transferring_request,
804 const std::vector<GURL>& transfer_url_chain, 745 const std::vector<GURL>& transfer_url_chain,
(...skipping 896 matching lines...) Expand 10 before | Expand all | Expand 10 after
1701 void RenderFrameHostImpl::DidUseGeolocationPermission() { 1642 void RenderFrameHostImpl::DidUseGeolocationPermission() {
1702 RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame(); 1643 RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame();
1703 GetContentClient()->browser()->RegisterPermissionUsage( 1644 GetContentClient()->browser()->RegisterPermissionUsage(
1704 PERMISSION_GEOLOCATION, 1645 PERMISSION_GEOLOCATION,
1705 delegate_->GetAsWebContents(), 1646 delegate_->GetAsWebContents(),
1706 GetLastCommittedURL().GetOrigin(), 1647 GetLastCommittedURL().GetOrigin(),
1707 top_frame->GetLastCommittedURL().GetOrigin()); 1648 top_frame->GetLastCommittedURL().GetOrigin());
1708 } 1649 }
1709 1650
1710 } // namespace content 1651 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698