Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 851333004: Add support to bisect nonofficial Android builds from tip of tree bot. (Closed)

Created:
5 years, 11 months ago by mikecase (-- gone --)
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support to bisect nonofficial Android builds from tip of tree bot. This change will allow Googlers to bisect over Android builds at a finer grain than what is currently possible (currently can only bisect over official builds for Android). BUG= Committed: https://crrev.com/e2b6ce8d537a567dc0881b0c9236861393d4255f Cr-Commit-Position: refs/heads/master@{#315071}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Addressed Sesek's comments. #

Patch Set 4 : Fixed mistake when rebasing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -67 lines) Patch
M tools/bisect-builds.py View 1 2 3 17 chunks +154 lines, -67 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
mikecase (-- gone --)
This CL adds support to bisect builds from one of the downstream bots. To answer ...
5 years, 11 months ago (2015-01-21 21:40:32 UTC) #2
mikecase (-- gone --)
On 2015/01/21 21:40:32, mikecase wrote: > This CL adds support to bisect builds from one ...
5 years, 10 months ago (2015-02-02 18:21:36 UTC) #3
Robert Sesek
Sorry, this slipped through my inbox. https://codereview.chromium.org/851333004/diff/20001/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/851333004/diff/20001/tools/bisect-builds.py#newcode543 tools/bisect-builds.py:543: nit: add another ...
5 years, 10 months ago (2015-02-04 17:27:54 UTC) #4
mikecase (-- gone --)
Thanks for reviewing this :D https://codereview.chromium.org/851333004/diff/20001/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/851333004/diff/20001/tools/bisect-builds.py#newcode543 tools/bisect-builds.py:543: On 2015/02/04 17:27:54, Robert ...
5 years, 10 months ago (2015-02-04 22:50:44 UTC) #5
Robert Sesek
lgtm
5 years, 10 months ago (2015-02-05 17:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851333004/60001
5 years, 10 months ago (2015-02-06 18:03:25 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-06 18:22:48 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 18:23:27 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e2b6ce8d537a567dc0881b0c9236861393d4255f
Cr-Commit-Position: refs/heads/master@{#315071}

Powered by Google App Engine
This is Rietveld 408576698