LayoutTests/media/track/track-cue-rendering-position-auto-rtl-expected.html - Issue 851333003: WebVTT: Update cue alignment to a later spec. version

Side by Side Diff: LayoutTests/media/track/track-cue-rendering-position-auto-rtl-expected.html

Issue 851333003: WebVTT: Update cue alignment to a later spec. version (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Added test. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../media-file.js"></script>	2 <script src="../media-file.js"></script>

3 <script>	3 <script>

4 var mediaFile = findMediaFile('video', '../content/test');	4 var mediaFile = findMediaFile('video', '../content/test');

5 </script>	5 </script>

6 <style>	6 <style>

7 .container {	7 .container {

8 position: relative;	8 position: relative;

9 display: inline-block;	9 display: inline-block;

10 width: 320px;	10 width: 320px;

11 height: 240px;	11 height: 240px;

12 }	12 }

13 .cue {	13 .cue {

14 position: absolute;	14 position: absolute;

15 top: 0;	15 top: 0;

16 left: 0;	16 left: 0;

17 right: 0;	17 right: 0;

18 overflow: hidden;	18 overflow: hidden;

19 }	19 }

20 .cue.start {	20 .cue.start {

21 text-align: start;	21 right: 50%;
	philipj_slow 2015/01/22 15:27:59 The input here was { align: 'start', size: 50, lin The input here was { align: 'start', size: 50, line: 0 } but I'm unable to convince myself that this is correct. position is auto and align is start, and so the computed text position should be 0, but this and the expectations seem to say 50, in line with the old way before position auto. I'm probably just confused about where we are in this patch series, why does this make sense? philipj_slow 2015/01/22 15:44:24 I'm just confused. The resulting box in which to p Show quoted text On 2015/01/22 15:27:59, philipj wrote: > The input here was { align: 'start', size: 50, line: 0 } but I'm unable to > convince myself that this is correct. position is auto and align is start, and > so the computed text position should be 0, but this and the expectations seem to > say 50, in line with the old way before position auto. I'm probably just > confused about where we are in this patch series, why does this make sense? I'm just confused. The resulting box in which to position the text has left:0 and width:50% so it's expected that RTL text will end up aligned against the middle. This is exactly what we wanted when we changed the spec, so that text directionality doesn't change the part of the screen which may be occupied.
	22 text-align: end;

22 }	23 }

23 .cue.middle {	24 .cue.middle {

24 text-align: center;	25 text-align: center;

25 }	26 }

26 .cue.end {	27 .cue.end {

27 text-align: end;	28 left: 50%;

	29 text-align: start;

28 }	30 }

29 .cue > span {	31 .cue > span {

30 font-family: sans-serif;	32 font-family: sans-serif;

31 background: green;	33 background: green;

32 color: green;	34 color: green;

33 font-size: 50px;	35 font-size: 50px;

34 padding: 2px;	36 padding: 2px;

35 }	37 }

36 </style>	38 </style>

37 <div class="container">	39 <div class="container">

38 <video><script>document.currentScript.parentNode.src = mediaFile;</script></vi deo>	40 <video><script>document.currentScript.parentNode.src = mediaFile;</script></vi deo>

39 <div class=video><div class="cue start"><span>XXX</span></div></div>	41 <div class=video><div class="cue start"><span>אבג</span></di v></div>

40 </div>	42 </div>

41 <div class="container">	43 <div class="container">

42 <video><script>document.currentScript.parentNode.src = mediaFile;</script></vi deo>	44 <video><script>document.currentScript.parentNode.src = mediaFile;</script></vi deo>

43 <div class=video><div class="cue middle"><span>XXX</span></div></div>	45 <div class=video><div class="cue middle"><span>אבג</span></d iv></div>

44 </div>	46 </div>

45 <div class="container">	47 <div class="container">

46 <video><script>document.currentScript.parentNode.src = mediaFile;</script></vi deo>	48 <video><script>document.currentScript.parentNode.src = mediaFile;</script></vi deo>

47 <div class=video><div class="cue end"><span>XXX</span></div></div>	49 <div class=video><div class="cue end"><span>אבג</span></div> </div>

48 </div>	50 </div>

OLD	NEW

« no previous file with comments | « LayoutTests/media/track/track-cue-rendering-position-auto-rtl.html ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »