Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 851333002: Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (Closed)

Created:
5 years, 11 months ago by bshe
Modified:
5 years, 11 months ago
Reviewers:
Shu Chen, Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText Previously, only text before cursor will be removed regardless the value of offset. This CL adds support for deleting text after cursor. We want to this feature in order to implement "set existing word to composition mode" feature when cursor is moved inside an existing word. We want to be able to remove the parts of the existing word before cursor and after cursor first and then call setComposition to set the word to composition mode. Note: this API tries to comform the API spec of ibus delete_surrounding_text here: ibus.googlecode.com/svn/docs/ibus-1.5/IBusInputContext.html#IBusInputContext-delete-surrounding-text A noticible difference is a positive offset value in this API does not take effect. BUG=446249 Committed: https://crrev.com/756820cb2c42a7b302a16d24909d820ee18dad0e Cr-Commit-Position: refs/heads/master@{#312113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bshe
Hey guys. Do you mind to take a look at this CL? I am in ...
5 years, 11 months ago (2015-01-16 21:02:06 UTC) #2
Seigo Nonaka
LGTM I'm sorry for my late response. FYI, this limitation was due to the past ...
5 years, 11 months ago (2015-01-18 23:25:34 UTC) #3
Shu Chen
lgtm
5 years, 11 months ago (2015-01-19 00:48:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851333002/1
5 years, 11 months ago (2015-01-19 14:25:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 15:14:19 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/756820cb2c42a7b302a16d24909d820ee18dad0e Cr-Commit-Position: refs/heads/master@{#312113}
5 years, 11 months ago (2015-01-19 15:15:36 UTC) #8
Shu Chen
5 years, 11 months ago (2015-01-21 00:47:43 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/821233003/ by shuchen@chromium.org.

The reason for reverting is: This cl caused regression that the
backspace-to-decommit feature for both VK and physical keyboard autocorrect.
.

Powered by Google App Engine
This is Rietveld 408576698