Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2699)

Unified Diff: net/quic/quic_headers_stream_test.cc

Issue 851323005: Fix bugs in QuicHeadersStreamTest in which client-mode was not being (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@quic_client_bin_cc_secure_QUIC_83647038
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_headers_stream_test.cc
diff --git a/net/quic/quic_headers_stream_test.cc b/net/quic/quic_headers_stream_test.cc
index 1ebab0b744d6a4f68a45a897a529b8454cff9041..7095d19f564011bae8a08b23c5da6aa22abd156e 100644
--- a/net/quic/quic_headers_stream_test.cc
+++ b/net/quic/quic_headers_stream_test.cc
@@ -81,7 +81,7 @@ struct TestParams {
friend ostream& operator<<(ostream& os, const TestParams& p) {
os << "{ version: " << QuicVersionToString(p.version);
- os << " is_server: " << p.is_server << " }";
+ os << ", is_server: " << p.is_server << " }";
return os;
}
@@ -94,7 +94,7 @@ vector<TestParams> GetTestParams() {
vector<TestParams> params;
QuicVersionVector all_supported_versions = QuicSupportedVersions();
for (const QuicVersion version : all_supported_versions) {
- params.push_back(TestParams(version, true));
+ params.push_back(TestParams(version, false));
params.push_back(TestParams(version, true));
}
return params;
@@ -247,7 +247,8 @@ TEST_P(QuicHeadersStreamTest, WriteHeaders) {
WriteHeadersAndExpectSynReply(stream_id, fin);
} else {
for (QuicPriority priority = 0; priority < 7; ++priority) {
- WriteHeadersAndExpectSynStream(stream_id, fin, priority);
+ // TODO(rch): implement priorities correctly.
+ WriteHeadersAndExpectSynStream(stream_id, fin, 0);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698