Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 851313004: Revert of linux/gyp: Find missing symbols at build time, not runtime. (Closed)

Created:
5 years, 11 months ago by Lei Zhang
Modified:
5 years, 11 months ago
Reviewers:
jamesr, Nico, DaleCurtis, piman
CC:
chromium-reviews, sadrul, tdresser+watch_chromium.org, tfarina, jam, dcheng, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of linux/gyp: Find missing symbols at build time, not runtime. (patchset #9 id:160001 of https://codereview.chromium.org/854753002/) Reason for revert: Broke Ozone: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/10001 gyp: Dependency '/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/build/linux/system.gyp:x11#target' not found while trying to load target /b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/content/content_shell_and_tests.gyp:test_netscape_plugin#target Original issue's description: > linux/gyp: Find missing symbols at build time, not runtime. > > Limited to very few cases for now (non-chromeos, non-android, > non-official, component builds only). > > BUG=371125 > TBR=piman,dalecurtis > > Committed: https://crrev.com/faffc1a04d17dd977ff9eb335c0c67b3b86dad5e > Cr-Commit-Position: refs/heads/master@{#312020} TBR=jamesr@chromium.org,piman@chromium.org,dalecurtis@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371125 Committed: https://crrev.com/c160801498b80b35d85758f254f24e337f27d265 Cr-Commit-Position: refs/heads/master@{#312028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/gpu_config.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/media_cdm.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/display/display.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/events.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/platform/x11/x11_events_platform.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
Created Revert of linux/gyp: Find missing symbols at build time, not runtime.
5 years, 11 months ago (2015-01-17 08:15:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851313004/1
5 years, 11 months ago (2015-01-17 08:15:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-17 08:16:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c160801498b80b35d85758f254f24e337f27d265 Cr-Commit-Position: refs/heads/master@{#312028}
5 years, 11 months ago (2015-01-17 08:17:31 UTC) #4
Nico
5 years, 11 months ago (2015-01-17 08:45:08 UTC) #5
Message was sent while issue was closed.
Fucking ozone.

Thanks for the revert!

Powered by Google App Engine
This is Rietveld 408576698