Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 851243002: Migrate TRACED_FOREACH to C++11. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate TRACED_FOREACH to C++11. R=svenpanne@chromium.org Committed: https://crrev.com/a0859c26bf569611ffddbd90eb431fe683667687 Cr-Commit-Position: refs/heads/master@{#26096}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M testing/gtest-support.h View 2 chunks +8 lines, -11 lines 1 comment Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-16 08:22:23 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-16 08:22:38 UTC) #2
Sven Panne
https://codereview.chromium.org/851243002/diff/1/testing/gtest-support.h File testing/gtest-support.h (right): https://codereview.chromium.org/851243002/diff/1/testing/gtest-support.h#newcode38 testing/gtest-support.h:38: for (_type const _var : _container) \ I know ...
5 years, 11 months ago (2015-01-16 08:30:38 UTC) #3
Sven Panne
LGTM. As discussed offline: Let's first land this as it is, and perhaps remove the ...
5 years, 11 months ago (2015-01-16 09:55:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851243002/1
5 years, 11 months ago (2015-01-16 09:56:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 10:40:31 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 10:40:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0859c26bf569611ffddbd90eb431fe683667687
Cr-Commit-Position: refs/heads/master@{#26096}

Powered by Google App Engine
This is Rietveld 408576698