Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 851233002: [Win] Fix black screen when min/maximizing hidden app window. (Closed)

Created:
5 years, 11 months ago by jackhou1
Modified:
5 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] Fix black screen when min/maximizing hidden app window. On Windows, an app window that is initialized with hidden:true and state:'maximized' will start visible and maximized, but its content is all black. This is because maximizing a hidden window on Windows causes the window to be shown, but this path does not also trigger the content to show. This CL is a temporary fix to prevent the above state without changing the current behavior. App windows that are initially hidden will not also be maximized, minimized, or fullscreen. On Windows, maximizing or minimizing hidden app windows will cause them to be shown. In the long term, we want the behavior on Windows to match CrOS where calling maximize() on a hidden window does nothing, and the next show() will show the window maximized. BUG=436867 Committed: https://crrev.com/3d1fd029975c325129474b9d4e262940d99ab375 Cr-Commit-Position: refs/heads/master@{#312061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M chrome/browser/ui/views/apps/app_window_desktop_native_widget_aura_win.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_desktop_native_widget_aura_win.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
benwells, WDYT?
5 years, 11 months ago (2015-01-16 06:04:23 UTC) #2
benwells
lgtm
5 years, 11 months ago (2015-01-19 01:17:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851233002/1
5 years, 11 months ago (2015-01-19 01:44:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 03:45:43 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 03:46:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d1fd029975c325129474b9d4e262940d99ab375
Cr-Commit-Position: refs/heads/master@{#312061}

Powered by Google App Engine
This is Rietveld 408576698