Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 851173002: Dart: Encode/Decode handle and interface types. (Closed)

Created:
5 years, 11 months ago by zra
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Encode/Decode handle and interface types. Adds sample_service_test.dart to test. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/635700e2685d52afc42464a5fc1362872e4119cb

Patch Set 1 #

Patch Set 2 : Fix Interface encode parameters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -114 lines) Patch
M mojo/dart/embedder/test/dart_to_cpp_tests.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/dart/embedder/test/run_dart_tests.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/dart/test/core_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A mojo/dart/test/sample_service_test.dart View 1 chunk +80 lines, -0 lines 0 comments Download
M mojo/public/dart/src/buffer.dart View 5 chunks +14 lines, -21 lines 0 comments Download
M mojo/public/dart/src/client.dart View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/dart/src/codec.dart View 1 6 chunks +183 lines, -10 lines 0 comments Download
M mojo/public/dart/src/data_pipe.dart View 8 chunks +33 lines, -34 lines 0 comments Download
M mojo/public/dart/src/event_stream.dart View 3 chunks +26 lines, -5 lines 0 comments Download
M mojo/public/dart/src/interface.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 4 chunks +39 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 1 8 chunks +51 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
5 years, 11 months ago (2015-01-15 21:57:04 UTC) #2
abarth-chromium
LGTM Yay for better types
5 years, 11 months ago (2015-01-15 22:19:43 UTC) #3
zra
5 years, 11 months ago (2015-01-15 23:00:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
635700e2685d52afc42464a5fc1362872e4119cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698