Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 851163006: UBSAN fixes. (Closed)

Created:
5 years, 11 months ago by inferno
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make UBSAN vptr work inside UBSAN and also add the UNDEFINED_SANITIZER define. Also, these can share the same blacklist file due to seperate prefixes. TBR=glider@chromium.org,jochen@chromium.org BUG= Committed: https://crrev.com/ac18f489dca8c902e4dfaa1a28d716b7914121d0 Cr-Commit-Position: refs/heads/master@{#312207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -96 lines) Patch
M build/common.gypi View 5 chunks +13 lines, -7 lines 0 comments Download
A + tools/ubsan/blacklist.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/ubsan_vptr/blacklist.txt View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
inferno
5 years, 11 months ago (2015-01-16 20:56:12 UTC) #2
Martin Barbella
LGTM
5 years, 11 months ago (2015-01-16 21:01:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851163006/1
5 years, 11 months ago (2015-01-16 21:02:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/15726)
5 years, 11 months ago (2015-01-16 22:08:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851163006/1
5 years, 11 months ago (2015-01-16 22:09:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/15710)
5 years, 11 months ago (2015-01-16 22:10:28 UTC) #11
Alexander Potapenko
LGTM
5 years, 11 months ago (2015-01-19 12:34:24 UTC) #12
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-20 15:50:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851163006/1
5 years, 11 months ago (2015-01-20 16:15:21 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 16:16:17 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:17:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac18f489dca8c902e4dfaa1a28d716b7914121d0
Cr-Commit-Position: refs/heads/master@{#312207}

Powered by Google App Engine
This is Rietveld 408576698