include/gpu/GrXferProcessor.h - Issue 851143003: Remove willReadDst from GrFragmentProcessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/gpu/GrXferProcessor.h

Issue 851143003: Remove willReadDst from GrFragmentProcessor. (Closed) Base URL: https://skia.googlesource.com/skia.git@xferXP

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/gpu/GrXferProcessor.h

diff --git a/include/gpu/GrXferProcessor.h b/include/gpu/GrXferProcessor.h

index 2c9961fc6b625cc231fd001aa1f9270f00910e69..13e4d2633ff30045b816db20b999744953a20ee7 100644

--- a/include/gpu/GrXferProcessor.h

+++ b/include/gpu/GrXferProcessor.h

@@ -205,10 +205,7 @@ public:

/**

* Returns true if the XP generated by this factory will read dst.

- // TODO: Currently this function must also check if the color/coverage stages read dst.

- // Once only XP's can read dst we can remove the ProcOptInfo's from this function.

- virtual bool willReadDst(const GrProcOptInfo& colorPOI,

- const GrProcOptInfo& coveragePOI) const = 0;

+ virtual bool willReadDst() const = 0;

bool isEqual(const GrXPFactory& that) const {

if (this->classID() != that.classID()) {