Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 851143003: Remove willReadDst from GrFragmentProcessor. (Closed)

Created:
5 years, 11 months ago by egdaniel
Modified:
5 years, 11 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xferXP
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove willReadDst from GrFragmentProcessor. Since only XP's can read dst now, there is no reason to have this query on GrFP. This also triggered a chain reaction of cleaning up/removing unnecessary code elsewhere. BUG=skia: Committed: https://skia.googlesource.com/skia/+/71e236c03e65ff6b48a3d0eb091f814dd3e3a928

Patch Set 1 #

Total comments: 4

Patch Set 2 : review nit #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -125 lines) Patch
M include/gpu/GrFragmentProcessor.h View 4 chunks +0 lines, -12 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 chunk +1 line, -4 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 3 chunks +0 lines, -7 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 5 chunks +2 lines, -31 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
egdaniel
5 years, 11 months ago (2015-01-15 20:32:50 UTC) #2
bsalomon
nice cleanup, lgtm https://codereview.chromium.org/851143003/diff/1/include/gpu/effects/GrPorterDuffXferProcessor.h File include/gpu/effects/GrPorterDuffXferProcessor.h (left): https://codereview.chromium.org/851143003/diff/1/include/gpu/effects/GrPorterDuffXferProcessor.h#oldcode39 include/gpu/effects/GrPorterDuffXferProcessor.h:39: kNone_PrimaryOutputType, Do we use kNone? https://codereview.chromium.org/851143003/diff/1/src/gpu/GrDrawState.h ...
5 years, 11 months ago (2015-01-15 20:43:01 UTC) #3
egdaniel
https://codereview.chromium.org/851143003/diff/1/include/gpu/effects/GrPorterDuffXferProcessor.h File include/gpu/effects/GrPorterDuffXferProcessor.h (left): https://codereview.chromium.org/851143003/diff/1/include/gpu/effects/GrPorterDuffXferProcessor.h#oldcode39 include/gpu/effects/GrPorterDuffXferProcessor.h:39: kNone_PrimaryOutputType, On 2015/01/15 20:43:01, bsalomon wrote: > Do we ...
5 years, 11 months ago (2015-01-15 20:56:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851143003/40001
5 years, 11 months ago (2015-01-20 14:27:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 14:34:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/71e236c03e65ff6b48a3d0eb091f814dd3e3a928

Powered by Google App Engine
This is Rietveld 408576698