Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 8511053: Cleanup: Remove unneeded forward declarations in chrome/installer. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations in chrome/installer. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109804

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 5

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -34 lines) Patch
M chrome/installer/setup/chrome_frame_ready_mode.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/install_worker.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/uninstall.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/app_commands.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.h View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
M chrome/installer/util/helper.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/installation_state.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/installation_validator.h View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/installer/util/product.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/installer/util/registry_key_backup.h View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 10:06:15 UTC) #1
grt (UTC plus 2)
Awesome. Thanks for doing this. http://codereview.chromium.org/8511053/diff/7004/chrome/installer/util/product.h File chrome/installer/util/product.h (right): http://codereview.chromium.org/8511053/diff/7004/chrome/installer/util/product.h#newcode20 chrome/installer/util/product.h:20: class ChannelInfo; This is ...
9 years, 1 month ago (2011-11-11 14:48:42 UTC) #2
Lei Zhang
http://codereview.chromium.org/8511053/diff/7004/chrome/installer/util/product.h File chrome/installer/util/product.h (right): http://codereview.chromium.org/8511053/diff/7004/chrome/installer/util/product.h#newcode20 chrome/installer/util/product.h:20: class ChannelInfo; On 2011/11/11 14:48:42, grt wrote: > This ...
9 years, 1 month ago (2011-11-11 19:50:52 UTC) #3
grt (UTC plus 2)
LGTM http://codereview.chromium.org/8511053/diff/7004/chrome/installer/util/product.h File chrome/installer/util/product.h (right): http://codereview.chromium.org/8511053/diff/7004/chrome/installer/util/product.h#newcode20 chrome/installer/util/product.h:20: class ChannelInfo; On 2011/11/11 19:50:53, Lei Zhang wrote: ...
9 years, 1 month ago (2011-11-12 01:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8511053/8001
9 years, 1 month ago (2011-11-12 15:48:00 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 17:20:18 UTC) #6
Change committed as 109804

Powered by Google App Engine
This is Rietveld 408576698