Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 851103007: Fixed version of https://codereview.chromium.org/748793002 (Closed)

Created:
5 years, 11 months ago by jsartisohn
Modified:
5 years, 9 months ago
Reviewers:
Mark Mentovai, smut
CC:
yukawa_g, adaubert
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed version of https://codereview.chromium.org/748793002 The original CL falsely added the inherited project path to the hashables of each child target even if the path wasn't unique. Not only was this undesired behavior and essentially a bug, but it also created an issue for very large projects like bling. The time it took to generate the project files went up from ~2min to over 20min. See https://code.google.com/p/chromium/issues/detail?id=447801 for more info. This CL fixes this behavior. BUG=447801

Patch Set 1 #

Patch Set 2 : Patch Set relative to https://codereview.chromium.org/748793002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pylib/gyp/xcodeproj_file.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
jsartisohn
5 years, 11 months ago (2015-01-19 16:53:55 UTC) #2
Nico
xcode->mark
5 years, 9 months ago (2015-02-27 00:03:47 UTC) #5
Mark Mentovai
Can you upload a patch set corresponding to what we had in https://codereview.chromium.org/748793002 followed by ...
5 years, 9 months ago (2015-02-27 01:29:18 UTC) #6
jsartisohn
On 2015/02/27 01:29:18, Mark Mentovai wrote: > Can you upload a patch set corresponding to ...
5 years, 9 months ago (2015-02-27 19:49:14 UTC) #7
Mark Mentovai
LGTM
5 years, 9 months ago (2015-02-27 19:59:51 UTC) #8
jsartisohn
On 2015/02/27 19:59:51, Mark Mentovai wrote: > LGTM Thanks for reviewing. FYI: I have no ...
5 years, 9 months ago (2015-02-27 21:04:15 UTC) #9
Mark Mentovai
Committed r2037
5 years, 9 months ago (2015-02-27 21:46:46 UTC) #10
natalie
5 years, 9 months ago (2015-03-02 23:32:59 UTC) #11
Message was sent while issue was closed.
On 2015/02/27 21:46:46, Mark Mentovai wrote:
> Committed r2037

Mentioned this on https://codereview.chromium.org/973493003 too (the git-repo
commit for this change).

This commit introduces a syntax error when attempting to run `sudo python
setup.py install` on a Mac:

byte-compiling build/bdist.macosx-10.10-intel/egg/gyp/xcodeproj_file.py to
xcodeproj_file.pyc
  File "build/bdist.macosx-10.10-intel/egg/gyp/xcodeproj_file.py", line 2761
    return True if symroots else return inherit_unique_symroot
                                      ^
SyntaxError: invalid syntax

I've encountered this with Mac OS 10.10.2 and 10.9.5 whic is what Travis CI uses
for Obj-C builds. The 2nd return should not be in that statement.

Powered by Google App Engine
This is Rietveld 408576698