Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 851073003: Remove unused includes of platform/graphics/media/MediaPlayer.h (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
CC:
blink-reviews, philipj_slow, arv+blink, feature-media-reviews_chromium.org, pdr+renderingwatchlist_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, Raymond Toy, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, blink-reviews-bindings_chromium.org, slimming-paint-reviews_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, zoltan1, blink-reviews-html_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused includes of platform/graphics/media/MediaPlayer.h All of the these files either don't reference MediaPlayer anymore, or have had uses replaced with uses of WebMediaPlayer instead. Also update some comments that was referring to MediaPlayer, and remove some other includes that was obviously not used. BUG=350571 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/VideoPainter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
fs
The MediaPlayer interface is being phased out (see bug), so this removes some includes that ...
5 years, 11 months ago (2015-01-15 12:24:52 UTC) #3
Jens Widell
LGTM
5 years, 11 months ago (2015-01-15 12:27:08 UTC) #4
sof
lgtm s/platforms/platform/ in commit message?
5 years, 11 months ago (2015-01-15 12:43:16 UTC) #5
haraken
LGTM
5 years, 11 months ago (2015-01-15 15:29:39 UTC) #6
fs
On 2015/01/15 12:43:16, sof wrote: > lgtm > > s/platforms/platform/ in commit message? Fixed, thanks.
5 years, 11 months ago (2015-01-15 15:37:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851073003/1
5 years, 11 months ago (2015-01-15 15:38:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188478
5 years, 11 months ago (2015-01-15 16:40:34 UTC) #10
ddorwin
5 years, 11 months ago (2015-01-15 17:12:30 UTC) #11
Message was sent while issue was closed.
modules/encryptedmedia/ LGTM

Powered by Google App Engine
This is Rietveld 408576698