Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 851073002: Fix remaining issues in the custom snapshot. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix remaining issues in the custom snapshot. Math functions: Some Math functions require typed arrays for their implementation. The embedded script may call those Math functions. The serializer needs to deal with this. Added assertion to make sure no other typed array is created when snapshotting. Number-string cache: We assume that the initial snapshot does not expand the number-string cache. This is no longer true for custom heap snapshots. Bound functions: Bound functions store the bound arguments in a COW fixed array, including the bindee function. COW arrays are serialized into the startup snapshot and referenced in the partial snapshot via partial snapshot cache. However, the bindee function is context-dependent and must not be part of the startup snapshot. There is no need for bound functions to use a COW array though. R=jochen@chromium.org Committed: https://crrev.com/22e6958d63c56b332ed6e3a379e3bed25be2d1bf Cr-Commit-Position: refs/heads/master@{#26072}

Patch Set 1 #

Patch Set 2 : fixed assertion #

Patch Set 3 : fix heap snapshot test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -20 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/heap.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/serialize.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
Yang
5 years, 11 months ago (2015-01-15 09:03:31 UTC) #1
jochen (gone - plz use gerrit)
what would happen if our regular snapshot all of a sudden contains typed arrays?
5 years, 11 months ago (2015-01-15 09:16:44 UTC) #2
Yang
On 2015/01/15 09:16:44, jochen (slow) wrote: > what would happen if our regular snapshot all ...
5 years, 11 months ago (2015-01-15 09:29:24 UTC) #3
jochen (gone - plz use gerrit)
oh well lgtm
5 years, 11 months ago (2015-01-15 09:36:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851073002/1
5 years, 11 months ago (2015-01-15 09:37:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851073002/20001
5 years, 11 months ago (2015-01-15 09:55:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2090) v8_linux_dbg on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/2137)
5 years, 11 months ago (2015-01-15 10:17:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851073002/40001
5 years, 11 months ago (2015-01-15 10:55:46 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-15 11:22:11 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 11:22:29 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22e6958d63c56b332ed6e3a379e3bed25be2d1bf
Cr-Commit-Position: refs/heads/master@{#26072}

Powered by Google App Engine
This is Rietveld 408576698