Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: sky/engine/core/rendering/style/RenderStyle.h

Issue 851033002: Simplify the paint invalidation bits. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: add one more check Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1348 matching lines...) Expand 10 before | Expand all | Expand 10 after
1359 Color color() const; 1359 Color color() const;
1360 StyleColor outlineColor() const { return m_background->outline().color(); } 1360 StyleColor outlineColor() const { return m_background->outline().color(); }
1361 StyleColor textEmphasisColor() const { return rareInheritedData->textEmphasi sColor(); } 1361 StyleColor textEmphasisColor() const { return rareInheritedData->textEmphasi sColor(); }
1362 StyleColor textFillColor() const { return rareInheritedData->textFillColor() ; } 1362 StyleColor textFillColor() const { return rareInheritedData->textFillColor() ; }
1363 StyleColor textStrokeColor() const { return rareInheritedData->textStrokeCol or(); } 1363 StyleColor textStrokeColor() const { return rareInheritedData->textStrokeCol or(); }
1364 1364
1365 StyleColor textDecorationColor() const { return rareNonInheritedData->m_text DecorationColor; } 1365 StyleColor textDecorationColor() const { return rareNonInheritedData->m_text DecorationColor; }
1366 1366
1367 void addAppliedTextDecoration(const AppliedTextDecoration&); 1367 void addAppliedTextDecoration(const AppliedTextDecoration&);
1368 1368
1369 // FIXME(sky): Combine these first two.
1369 bool diffNeedsFullLayoutAndPaintInvalidation(const RenderStyle& other) const ; 1370 bool diffNeedsFullLayoutAndPaintInvalidation(const RenderStyle& other) const ;
1370 bool diffNeedsFullLayout(const RenderStyle& other) const; 1371 bool diffNeedsFullLayout(const RenderStyle& other) const;
1371 bool diffNeedsPaintInvalidationLayer(const RenderStyle& other) const; 1372 bool diffNeedsPaintInvalidation(const RenderStyle& other) const;
1372 bool diffNeedsPaintInvalidationObject(const RenderStyle& other) const;
1373 bool diffNeedsRecompositeLayer(const RenderStyle& other) const; 1373 bool diffNeedsRecompositeLayer(const RenderStyle& other) const;
1374 void updatePropertySpecificDifferences(const RenderStyle& other, StyleDiffer ence&) const; 1374 void updatePropertySpecificDifferences(const RenderStyle& other, StyleDiffer ence&) const;
1375 }; 1375 };
1376 1376
1377 inline bool RenderStyle::isSharable() const 1377 inline bool RenderStyle::isSharable() const
1378 { 1378 {
1379 return !unique(); 1379 return !unique();
1380 } 1380 }
1381 1381
1382 inline bool RenderStyle::setTextOrientation(TextOrientation textOrientation) 1382 inline bool RenderStyle::setTextOrientation(TextOrientation textOrientation)
1383 { 1383 {
1384 if (compareEqual(rareInheritedData->m_textOrientation, textOrientation)) 1384 if (compareEqual(rareInheritedData->m_textOrientation, textOrientation))
1385 return false; 1385 return false;
1386 1386
1387 rareInheritedData.access()->m_textOrientation = textOrientation; 1387 rareInheritedData.access()->m_textOrientation = textOrientation;
1388 return true; 1388 return true;
1389 } 1389 }
1390 1390
1391 float calcBorderRadiiConstraintScaleFor(const FloatRect&, const FloatRoundedRect ::Radii&); 1391 float calcBorderRadiiConstraintScaleFor(const FloatRect&, const FloatRoundedRect ::Radii&);
1392 1392
1393 } // namespace blink 1393 } // namespace blink
1394 1394
1395 #endif // SKY_ENGINE_CORE_RENDERING_STYLE_RENDERSTYLE_H_ 1395 #endif // SKY_ENGINE_CORE_RENDERING_STYLE_RENDERSTYLE_H_
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderObject.cpp ('k') | sky/engine/core/rendering/style/RenderStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698