Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 851013002: Swarm media_unittests. (Closed)

Created:
5 years, 11 months ago by jam
Modified:
5 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Swarm media_unittests. BUG=448877 Committed: https://crrev.com/21d6f8e72b63fb5840951160030980ee63666ba5 Cr-Commit-Position: refs/heads/master@{#311756} Committed: https://crrev.com/3e7dffcba9ee0ae3d96ac1b022af4768e26fe8e5 Cr-Commit-Position: refs/heads/master@{#312206}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -23 lines) Patch
M media/media.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/media_unittests.isolate View 1 2 3 1 chunk +39 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 3 chunks +18 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 4 chunks +24 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 5 chunks +30 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 1 chunk +6 lines, -1 line 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
jam
5 years, 11 months ago (2015-01-15 16:36:31 UTC) #2
scherkus (not reviewing)
lgtm w/ question thanks!! https://codereview.chromium.org/851013002/diff/40001/media/media_unittests.isolate File media/media_unittests.isolate (left): https://codereview.chromium.org/851013002/diff/40001/media/media_unittests.isolate#oldcode9 media/media_unittests.isolate:9: ['OS=="android" or OS=="linux" or OS=="mac" ...
5 years, 11 months ago (2015-01-15 19:21:54 UTC) #3
jam
https://codereview.chromium.org/851013002/diff/40001/media/media_unittests.isolate File media/media_unittests.isolate (left): https://codereview.chromium.org/851013002/diff/40001/media/media_unittests.isolate#oldcode9 media/media_unittests.isolate:9: ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', { On ...
5 years, 11 months ago (2015-01-15 21:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851013002/40001
5 years, 11 months ago (2015-01-15 21:17:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/1476)
5 years, 11 months ago (2015-01-15 22:53:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851013002/40001
5 years, 11 months ago (2015-01-15 23:04:44 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-15 23:07:34 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/21d6f8e72b63fb5840951160030980ee63666ba5 Cr-Commit-Position: refs/heads/master@{#311756}
5 years, 11 months ago (2015-01-15 23:08:20 UTC) #12
ricow1
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/851123004/ by ricow@google.com. ...
5 years, 11 months ago (2015-01-16 10:38:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851013002/60001
5 years, 11 months ago (2015-01-20 15:49:26 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-20 16:12:03 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:13:07 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3e7dffcba9ee0ae3d96ac1b022af4768e26fe8e5
Cr-Commit-Position: refs/heads/master@{#312206}

Powered by Google App Engine
This is Rietveld 408576698