content/renderer/media/android/webmediaplayer_android.cc - Issue 850993002: gpu video: optimize HW video to SW canvas and implement it for WebRTC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 850993002: gpu video: optimize HW video to SW canvas and implement it for WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android build fail Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_browsertest.cc ('k') | content/renderer/media/renderer_gpu_video_accelerator_factories.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/webmediaplayer_android.cc

diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc

index e0b77067760f2aefdefe6b363bd2c2c381d258ac..d54c8264d762b393c50e9a65b60f27acddc1b726 100644

--- a/content/renderer/media/android/webmediaplayer_android.cc

+++ b/content/renderer/media/android/webmediaplayer_android.cc

@@ -1190,7 +1190,7 @@ void WebMediaPlayerAndroid::DrawRemotePlaybackText(

remote_playback_texture_id)),

canvas_size /* coded_size */, gfx::Rect(canvas_size) /* visible_rect */,

canvas_size /* natural_size */, base::TimeDelta() /* timestamp */,

- VideoFrame::ReadPixelsCB(), false /* allow overlay */);

+ false /* allow overlay */);

SetCurrentFrameInternal(new_frame);

}

@@ -1226,7 +1226,7 @@ void WebMediaPlayerAndroid::ReallocateVideoFrame() {

media::BindToCurrentLoop(base::Bind(

&OnReleaseTexture, stream_texture_factory_, texture_id_ref)),

natural_size_, gfx::Rect(natural_size_), natural_size_,

- base::TimeDelta(), VideoFrame::ReadPixelsCB(), false);

+ base::TimeDelta(), false);

SetCurrentFrameInternal(new_frame);

}