content/browser/renderer_host/render_widget_host_view_browsertest.cc - Issue 850993002: gpu video: optimize HW video to SW canvas and implement it for WebRTC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 850993002: gpu video: optimize HW video to SW canvas and implement it for WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_host_unittest_context.cc ('K') | « content/browser/renderer_host/media/video_capture_controller_unittest.cc ('k') | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_browsertest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

index 920a143869dc61522ad7b50bfe6d5389210b5133..f473414ead926ff545824dcf9d9a3f08aa0f2fb6 100644

--- a/content/browser/renderer_host/render_widget_host_view_browsertest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

@@ -476,7 +476,7 @@ class CompositingRenderWidgetHostViewBrowserTestTabCapture

video_frame->visible_rect().height());

// Don't clear the canvas because drawing a video frame by Src mode.

SkCanvas canvas(bitmap);

- video_renderer.Copy(video_frame, &canvas);

+ video_renderer.Copy(video_frame, &canvas, media::Context3D());

ReadbackResponse response = result ? READBACK_SUCCESS : READBACK_FAILED;

ReadbackRequestCallbackTest(quit_callback, bitmap, response);