cc/resources/video_resource_updater.cc - Issue 850993002: gpu video: optimize HW video to SW canvas and implement it for WebRTC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/video_resource_updater.cc

Issue 850993002: gpu video: optimize HW video to SW canvas and implement it for WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/video_resource_updater.cc

diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc

index f6d08d1e3f98e07c0c64c7931af0248fa436c417..bfdea4a2a86fba63cfeb24449fb3fa4e1caa613f 100644

--- a/cc/resources/video_resource_updater.cc

+++ b/cc/resources/video_resource_updater.cc

@@ -294,7 +294,7 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(

ResourceProvider::ScopedWriteLockSoftware lock(

resource_provider_, plane_resource.resource_id);

SkCanvas canvas(lock.sk_bitmap());

- video_renderer_->Copy(video_frame, &canvas);

+ video_renderer_->Copy(video_frame, &canvas, media::Context3D());

dshwang 2015/01/21 13:40:32 this is software path, so canvas and video_frame a

danakj 2015/02/10 17:48:12 how about making this a comment in the code?

SetPlaneResourceUniqueId(video_frame.get(), 0, &plane_resource);

}

« no previous file with comments | « no previous file | cc/trees/layer_tree_host_unittest_context.cc » ('j') | cc/trees/layer_tree_host_unittest_context.cc » ('J')