remoting/proto/video.proto - Issue 850983002: Implement video frame acknowledgements in the chromoting protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/proto/video.proto

Issue 850983002: Implement video frame acknowledgements in the chromoting protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/video_scheduler.cc ('K') | « remoting/host/video_scheduler_unittest.cc ('k') | remoting/protocol/channel_dispatcher_base.h » ('j') | remoting/protocol/channel_dispatcher_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/proto/video.proto

diff --git a/remoting/proto/video.proto b/remoting/proto/video.proto

index 0ee29c9b8922d65c30dfb653fa32db538104eb79..509694121cf161d720eb57d031e8e2f274f7a061 100644

--- a/remoting/proto/video.proto

+++ b/remoting/proto/video.proto

@@ -66,4 +66,18 @@ message VideoPacket {

// Optional frame timestamp. Used in tests to estimate frame latency.

optional int64 timestamp = 12;

+ optional int32 frame_id = 13;

+message VideoAck {

+ // Frame ID.

+ optional int32 frame_id = 1;

+ // Time in microseconds it took to receive this frame from the beginning to

+ // the end.

Wez 2015/01/21 01:35:38 nit: to receive the VideoPacket. Also consider no

Sergey Ulanov 2015/01/29 01:33:28 Done.

+ optional int32 time_to_receive_us = 2;

+ // Time in microseconds it took to render the frame.

+ optional int32 rendering_delay_us = 3;

}