Implement video frame acknowledgements in the chromoting protocol.

remoting/protocol/video_stub.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_VIDEO_STUB_H_
 #define REMOTING_PROTOCOL_VIDEO_STUB_H_
 
 #include "base/callback_forward.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace remoting {
 
 class VideoPacket;
 
 namespace protocol {
 
 class VideoStub {
  public:
-  virtual void ProcessVideoPacket(scoped_ptr<VideoPacket> video_packet,
-                                  const base::Closure& done) = 0;
+  // For each packet VideoStub calls the specified ProgressCallback to
+  // notify about packet progress. SENT state may be skipped, if the packet is
+  // processed locally. If SupportsAcks() returns true then DONE progress
+  // notification is emitted only after the acknowledgment has been received.
+  enum class PacketProgress {
+    SENT,

[Wez, 2015/02/03 00:54:32]

Do we really need the "SENT" state? It ends up making this API uglier - "sent"
has a reasonably specific meaning, whereas "done" is pretty generic, so it's not
clear why we need both.

[Sergey Ulanov, 2015/02/09 19:14:54]

Reverted this change now. Using VideoFeedbackStub instead.

+    DONE,
+  };
+  typedef base::Callback<void(PacketProgress progress)> ProgressCallback;
+
+  virtual void ProcessVideoPacket(
+      scoped_ptr<VideoPacket> video_packet,
+      const ProgressCallback& progress_callback) = 0;

[Wez, 2015/02/03 00:54:32]

This complicates the VideoStub interface quite a bit; the model I had in mind
for these stubs would have a VideoAckStub or VideoSendStatusStub (or some better
name;) through which these acknowledgements would be received by the sender,
without VideoStub implementations necessarily needing to know about that path -
would that do what you need here?

[Sergey Ulanov, 2015/02/09 19:14:54]

Reverted this change now. Using VideoFeedbackStub instead.

+
+  // Indicates that the connection supports video packet acknowledgments.
+  virtual bool SupportsAcks() { return false; }
 
  protected:
   VideoStub() {}
   virtual ~VideoStub() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(VideoStub);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_VIDEO_STUB_H_