Implement video frame acknowledgements in the chromoting protocol.

remoting/protocol/client_video_dispatcher.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_CLIENT_VIDEO_DISPATCHER_H_
 #define REMOTING_PROTOCOL_CLIENT_VIDEO_DISPATCHER_H_
 
 #include "base/compiler_specific.h"
 #include "remoting/proto/video.pb.h"
 #include "remoting/protocol/channel_dispatcher_base.h"
 #include "remoting/protocol/protobuf_message_parser.h"
 
 namespace remoting {
 namespace protocol {
 
 class VideoStub;
 
 class ClientVideoDispatcher : public ChannelDispatcherBase {
  public:
   explicit ClientVideoDispatcher(VideoStub* video_stub);
   ~ClientVideoDispatcher() override;
 
  private:
+  void OnVideoPacket(scoped_ptr<VideoPacket> video_packet,
+                     const base::Closure& done);
+  void OnPacketProcessed(VideoAck ack_message,

[Wez, 2015/01/21 01:35:39]

const&

(Bind() should still copy the parameter into the closure, but you'll avoid an
extra copy when it is Run())

[Sergey Ulanov, 2015/01/29 01:33:28]

Done.

+                         base::TimeTicks received_time,
+                         const base::Closure& done);

[Wez, 2015/01/21 01:35:39]

Suggest more helpful naming, e.g. OnVideoPacket->ProcessVideoPacket and
OnPacketProcessed->AcknowledgeVideoPacket.

Or if you prefer to keep the names generic-sounding then add comments to explain
their purpose.

[Sergey Ulanov, 2015/01/29 01:33:28]

Renamed OnVideoPacket() only. OnPacketProcessed() is now OnPacketProgress(). It
doesn't always send ACK, only when the host expects it.

+
+  VideoStub* video_stub_;
   ProtobufMessageParser<VideoPacket> parser_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientVideoDispatcher);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_CLIENT_VIDEO_DISPATCHER_H_