Implement video frame acknowledgements in the chromoting protocol.

remoting/protocol/channel_dispatcher_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_CHANNEL_DISPATCHER_BASE_H_
 #define REMOTING_PROTOCOL_CHANNEL_DISPATCHER_BASE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "remoting/protocol/buffered_socket_writer.h"
 #include "remoting/protocol/errors.h"
 #include "remoting/protocol/message_reader.h"
+#include "remoting/protocol/session_config.h"
 
 namespace net {
 class StreamSocket;
 }  // namespace net
 
 namespace remoting {
 namespace protocol {
 
-struct ChannelConfig;
 class StreamChannelFactory;
 class Session;
 
 // Base class for channel message dispatchers. It's responsible for
 // creating the named channel. Derived dispatchers then dispatch
 // incoming messages on this channel as well as send outgoing
 // messages.
 class ChannelDispatcherBase {
  public:
   class EventHandler {
@@ skipping 13 matching lines @@
 
   virtual ~ChannelDispatcherBase();
 
   // Creates and connects the channel in the specified
   // |session|. Caller retains ownership of the Session.
   void Init(Session* session,
             const ChannelConfig& config,
             EventHandler* event_handler);
 
   const std::string& channel_name() { return channel_name_; }
+  const ChannelConfig& channel_config() { return channel_config_; }

[Wez, 2015/01/21 01:35:38]

Does this need to be public, or could it be protected? Do only derived classes
need to poke at the config, or other code as well?

[Sergey Ulanov, 2015/01/29 01:33:28]

Yes, it's better to make it protected. Done.

 
   // Returns true if the channel is currently connected.
   bool is_connected() { return channel_ != nullptr; }
 
  protected:
   explicit ChannelDispatcherBase(const char* channel_name);
 
+  void NotifyError(ErrorCode error);

[Wez, 2015/01/21 01:35:38]

Do you need this, or could you just expose an event_handler() getter and let
callers do it?

If you feel this is cleaner then suggest comment:
"Calls event_handler_->OnChannelError() with the supplied |error|" to make clear
that that's all it does.

[Sergey Ulanov, 2015/01/29 01:33:28]

Yes, I think it's better to have this method instead of using event_handler_
directly.
Done.

+
   BufferedSocketWriter* writer() { return &writer_; }
   MessageReader* reader() { return &reader_; }
 
  private:
   void OnChannelReady(scoped_ptr<net::StreamSocket> socket);
   void OnWriteFailed(int error);
 
   std::string channel_name_;
   StreamChannelFactory* channel_factory_;
+  ChannelConfig channel_config_;
   EventHandler* event_handler_;
   scoped_ptr<net::StreamSocket> channel_;
 
   BufferedSocketWriter writer_;
   MessageReader reader_;
 
   DISALLOW_COPY_AND_ASSIGN(ChannelDispatcherBase);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_CHANNEL_DISPATCHER_BASE_H_