Issue 850963003: Dart: Updates Dart VM revision.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 850963003: Dart: Updates Dart VM revision. (Closed)

Created:
5 years, 11 months ago by zra

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Dart: Updates Dart VM revision. Among other improvements, this pulls in a change that enables async/await by default, and pulls in: https://codereview.chromium.org/850193002/ which allows scripts pulled into a snapshot to reference imports relative to a package root. This will allow Mojo Dart snapshots to reference generated bindings via a package root rather than creating special-case URIs for them. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/feb8184cf94fa893f5bc624343a91fabf9850d3f

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -6 lines)			Patch
M	DEPS.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/dart/embedder/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/dart/embedder/dart_controller.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

5 years, 11 months ago (2015-01-15 15:35:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
feb8184cf94fa893f5bc624343a91fabf9850d3f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages