Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 850943002: Remove MediaPlayer::invalidTime() (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
CC:
blink-reviews, krit, nessy, Dominik Röttsches, Rik, philipj_slow, gasubic, eric.carlson_apple.com, jbroman, danakj, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, f(malita), Stephen Chennney, pdr+graphicswatchlist_chromium.org, vcarbune.chromium, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove MediaPlayer::invalidTime() Remove MediaPlayer::invalidTime() (literal -1.0) replacing it with a NaN, which is similar to how HTMLMediaElement::m_duration is handled. Also remove MediaFragmentURIParser::invalidTimeValue() since it is unused. BUG=350571 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/MediaController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/MediaFragmentURIParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/MediaFragmentURIParser.cpp View 4 chunks +6 lines, -12 lines 0 comments Download
M Source/platform/graphics/media/MediaPlayer.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
This is wide open for bikeshedding, so go ahead and pick your favorite color!
5 years, 11 months ago (2015-01-14 15:29:19 UTC) #2
philipj_slow
This color LGTM
5 years, 11 months ago (2015-01-14 20:33:18 UTC) #3
fs
Mike/Jochen: Race to RS the single line removal in platform/? =)
5 years, 11 months ago (2015-01-15 09:19:08 UTC) #5
Mike West
LGTM I WIN!
5 years, 11 months ago (2015-01-15 09:40:07 UTC) #6
fs
On 2015/01/15 09:40:07, Mike West wrote: > LGTM I WIN! Congratulations! ___ .'__ '. / ...
5 years, 11 months ago (2015-01-15 10:10:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850943002/1
5 years, 11 months ago (2015-01-15 10:11:40 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 10:28:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188460

Powered by Google App Engine
This is Rietveld 408576698