Extensions: Consolidate extension id hashing / searching.

chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Tab Capture API.
 
 #include "chrome/browser/extensions/api/tab_capture/tab_capture_api.h"
 
 #include <set>
 #include <string>
@@ skipping 33 matching lines @@
     "Extension has not been invoked for the current page (see activeTab "
     "permission). Chrome pages cannot be captured.";
 
 // Keys/values for media stream constraints.
 const char kMediaStreamSource[] = "chromeMediaSource";
 const char kMediaStreamSourceId[] = "chromeMediaSourceId";
 const char kMediaStreamSourceTab[] = "tab";
 
 // Whitelisted extensions that do not check for a browser action grant because
 // they provide API's.
-const char* const whitelisted_extensions[] = {
+const char* const kWhitelist[] = {
   "enhhojjnijigcajfphajepfemndkmdlo",  // Dev
   "pkedcjkdefgpdelpbcmbmeomcjbeemfm",  // Trusted Tester
   "fmfcbgogabcbclcofgocippekhfcmgfj",  // Staging
   "hfaagokkkhdbgiakmmlclaapfelnkoah",  // Canary
   "F155646B5D1CA545F7E1E4E20D573DFDD44C2540",  // Trusted Tester (public)
   "16CA7A47AAE4BE49B1E75A6B960C3875E945B264"   // Release
 };
 
 }  // namespace
 
@@ skipping 21 matching lines @@
 
   // Make sure either we have been granted permission to capture through an
   // extension icon click or our extension is whitelisted.
   if (!extension()->permissions_data()->HasAPIPermissionForTab(
           SessionTabHelper::IdForTab(target_contents),
           APIPermission::kTabCaptureForTab) &&
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
           switches::kWhitelistedExtensionID) != extension_id &&
       !SimpleFeature::IsIdInList(
           extension_id,
-          std::set<std::string>(
-              whitelisted_extensions,
-              whitelisted_extensions + arraysize(whitelisted_extensions)))) {
+          std::set<std::string>(kWhitelist,
+                                kWhitelist + arraysize(kWhitelist)))) {
     error_ = kGrantError;
     return false;
   }
 
   // Create a constraints vector. We will modify all the constraints in this
   // vector to append our chrome specific constraints.
   std::vector<MediaStreamConstraint*> constraints;
   bool has_audio = params->options.audio.get() && *params->options.audio.get();
   bool has_video = params->options.video.get() && *params->options.video.get();
 
@@ skipping 25 matching lines @@
       main_frame->GetRoutingID());
 
   // Append chrome specific tab constraints.
   for (std::vector<MediaStreamConstraint*>::iterator it = constraints.begin();
        it != constraints.end(); ++it) {
     base::DictionaryValue* constraint = &(*it)->mandatory.additional_properties;
     constraint->SetString(kMediaStreamSource, kMediaStreamSourceTab);
     constraint->SetString(kMediaStreamSourceId, device_id);
   }
 
-  extensions::TabCaptureRegistry* registry =
-      extensions::TabCaptureRegistry::Get(GetProfile());
+  TabCaptureRegistry* registry = TabCaptureRegistry::Get(GetProfile());
   if (!registry->AddRequest(target_contents, extension_id)) {
     error_ = kCapturingSameTab;
     return false;
   }
 
   // Copy the result from our modified input parameters. This will be
   // intercepted by custom bindings which will build and send the special
   // WebRTC user media request.
   base::DictionaryValue* result = new base::DictionaryValue();
   result->MergeDictionary(params->options.ToValue().get());
 
   SetResult(result);
   return true;
 }
 
 bool TabCaptureGetCapturedTabsFunction::RunSync() {
-  extensions::TabCaptureRegistry* registry =
-      extensions::TabCaptureRegistry::Get(GetProfile());
+  TabCaptureRegistry* registry = TabCaptureRegistry::Get(GetProfile());
   base::ListValue* const list = new base::ListValue();
   if (registry)
     registry->GetCapturedTabs(extension()->id(), list);
   SetResult(list);
   return true;
 }
 
 }  // namespace extensions