Extensions: Consolidate extension id hashing / searching.

chrome/browser/background/background_application_list_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background/background_application_list_model.h"
 
 #include <algorithm>
 #include <set>
 
-#include "base/sha1.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/background/background_contents_service.h"
 #include "chrome/browser/background/background_contents_service_factory.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 264 matching lines @@
   // No PushMessaging permission - does not require the background mode.
   if (!extension.permissions_data()->HasAPIPermission(
           APIPermission::kPushMessaging)) {
     return false;
   }
 
   // If in the whitelist, then does not require background mode even if
   // uses push messaging.
   // TODO(dimich): remove this whitelist once we have a better way to keep
   // listening for GCM. http://crbug.com/311268
-  std::string id_hash = base::SHA1HashString(extension.id());
-  std::string hexencoded_id_hash = base::HexEncode(id_hash.c_str(),
-                                                   id_hash.length());
+  std::string hexencoded_id_hash = extension.HashedIdInHex();
   // The id starting from "9A04..." is a one from unit test.
   if (hexencoded_id_hash == "C41AD9DCD670210295614257EF8C9945AD68D86E" ||
       hexencoded_id_hash == "9A0417016F345C934A1A88F55CA17C05014EEEBA")
      return false;
 
-   return true;
- }
+  return true;
+}
 
 // static
 bool BackgroundApplicationListModel::IsBackgroundApp(
     const Extension& extension, Profile* profile) {
   // An extension is a "background app" if it has the "background API"
   // permission, and meets one of the following criteria:
   // 1) It is an extension (not a hosted app).
   // 2) It is a hosted app, and has a background contents registered or in the
   //    manifest.
 
@@ skipping 138 matching lines @@
          (*old_cursor)->name() == (*new_cursor)->name() &&
          (*old_cursor)->id() == (*new_cursor)->id()) {
     ++old_cursor;
     ++new_cursor;
   }
   if (old_cursor != extensions_.end() || new_cursor != extensions.end()) {
     extensions_ = extensions;
     FOR_EACH_OBSERVER(Observer, observers_, OnApplicationListChanged(profile_));
   }
 }