Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 850843003: MacViews: Remove redundant virtuals in NativeWidgetMac and co. (Closed)

Created:
5 years, 11 months ago by tapted
Modified:
5 years, 11 months ago
Reviewers:
Andre, sky
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20141229-MacViews-bringup2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Remove redundant virtuals in NativeWidgetMac and co. Strict virtual annotation checks were enabled on Mac in r311365. This gets toolkit_views for Mac on board. BUG=417463 Committed: https://crrev.com/d76706534d9d60bab5496bed0ba6299ed0557a11 Cr-Commit-Position: refs/heads/master@{#311528}

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -159 lines) Patch
M ui/views/cocoa/bridged_native_widget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget_unittest.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_message_loop_mac.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M ui/views/controls/menu/menu_runner_cocoa_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl_cocoa.h View 1 1 chunk +10 lines, -10 lines 0 comments Download
M ui/views/controls/native/native_view_host_mac.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ui/views/event_monitor_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/event_generator_delegate_mac.mm View 1 1 chunk +22 lines, -27 lines 0 comments Download
M ui/views/test/views_test_helper_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_mac.h View 1 2 chunks +83 lines, -86 lines 0 comments Download
M ui/views/widget/native_widget_mac_interactive_uitest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tapted
Hi sky, please take a look. Just a mechanical change.
5 years, 11 months ago (2015-01-14 10:26:56 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-14 16:25:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850843003/20001
5 years, 11 months ago (2015-01-14 18:47:49 UTC) #5
Andre
Queuing commit so I can pick it up.
5 years, 11 months ago (2015-01-14 18:48:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 19:11:12 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 19:12:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d76706534d9d60bab5496bed0ba6299ed0557a11
Cr-Commit-Position: refs/heads/master@{#311528}

Powered by Google App Engine
This is Rietveld 408576698