Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 850823003: Convert mojo gesture events into WebGestureEvents (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -4 lines) Patch
M sky/viewer/converters/input_event_types.cc View 4 chunks +103 lines, -4 lines 3 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-13 23:08:28 UTC) #1
eseidel
lgtm Very ugly. https://codereview.chromium.org/850823003/diff/1/sky/viewer/converters/input_event_types.cc File sky/viewer/converters/input_event_types.cc (right): https://codereview.chromium.org/850823003/diff/1/sky/viewer/converters/input_event_types.cc#newcode125 sky/viewer/converters/input_event_types.cc:125: case EVENT_TYPE_GESTURE_SCROLL_BEGIN: Double bleh. https://codereview.chromium.org/850823003/diff/1/sky/viewer/converters/input_event_types.cc#newcode323 sky/viewer/converters/input_event_types.cc:323: ...
5 years, 11 months ago (2015-01-13 23:20:39 UTC) #2
abarth-chromium
Committed patchset #1 (id:1) manually as ec364635914a97d970ae6bdbd6899b0339af5ca9 (presubmit successful).
5 years, 11 months ago (2015-01-13 23:23:20 UTC) #3
esprehn
5 years, 11 months ago (2015-01-13 23:32:11 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/850823003/diff/1/sky/viewer/converters/input_...
File sky/viewer/converters/input_event_types.cc (right):

https://codereview.chromium.org/850823003/diff/1/sky/viewer/converters/input_...
sky/viewer/converters/input_event_types.cc:129: web_event->type =
blink::WebInputEvent::GestureScrollEnd;
Can we use a lookup table instead?

Powered by Google App Engine
This is Rietveld 408576698