Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 850803002: First simple implementation of for-of in TurboFan. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
Reviewers:
rossberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

First simple implementation of for-of in TurboFan. R=rossberg@chromium.org TEST=cctest/test-run-jsbranches/ForOfContinueStatement Committed: https://crrev.com/2ebe24c9cb22452bc1f84744e21453b5afaf054a Cr-Commit-Position: refs/heads/master@{#26060}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M src/ast-numbering.cc View 2 chunks +3 lines, -3 lines 2 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/compiler/control-builders.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/control-builders.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-run-jsbranches.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-13 17:56:05 UTC) #1
adamk
https://codereview.chromium.org/850803002/diff/1/src/ast-numbering.cc File src/ast-numbering.cc (right): https://codereview.chromium.org/850803002/diff/1/src/ast-numbering.cc#newcode393 src/ast-numbering.cc:393: DisableCrankshaft(kForOfStatement); Does this mean that any function that happens ...
5 years, 11 months ago (2015-01-13 19:02:36 UTC) #3
Michael Starzinger
https://codereview.chromium.org/850803002/diff/1/src/ast-numbering.cc File src/ast-numbering.cc (right): https://codereview.chromium.org/850803002/diff/1/src/ast-numbering.cc#newcode393 src/ast-numbering.cc:393: DisableCrankshaft(kForOfStatement); On 2015/01/13 19:02:36, adamk wrote: > Does this ...
5 years, 11 months ago (2015-01-13 19:28:01 UTC) #4
rossberg
lgtm
5 years, 11 months ago (2015-01-14 13:48:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850803002/1
5 years, 11 months ago (2015-01-14 14:57:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 15:24:25 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 15:24:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ebe24c9cb22452bc1f84744e21453b5afaf054a
Cr-Commit-Position: refs/heads/master@{#26060}

Powered by Google App Engine
This is Rietveld 408576698