Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 850773004: Computed property names: Enable test on windows again (Closed)

Created:
5 years, 11 months ago by arv (Not doing code reviews)
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Computed property names: Enable test on windows again Enable test on windows again and disable the problematic lines only. BUG=v8:3815 LOG=N R=dslomov@chromium.org Committed: https://crrev.com/c8124f932c899e4b5d5381ab7fc88f7518a7c76d Cr-Commit-Position: refs/heads/master@{#26086}

Patch Set 1 #

Patch Set 2 : Full url in todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M test/mjsunit/harmony/computed-property-names.js View 1 1 chunk +6 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
arv (Not doing code reviews)
Full url in todo
5 years, 11 months ago (2015-01-15 21:28:01 UTC) #1
arv (Not doing code reviews)
PTAL
5 years, 11 months ago (2015-01-15 21:28:59 UTC) #2
adamk
lgtm
5 years, 11 months ago (2015-01-15 22:50:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850773004/20001
5 years, 11 months ago (2015-01-15 23:52:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:20:08 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:20:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8124f932c899e4b5d5381ab7fc88f7518a7c76d
Cr-Commit-Position: refs/heads/master@{#26086}

Powered by Google App Engine
This is Rietveld 408576698