Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: sky/engine/core/rendering/RenderView.cpp

Issue 850763008: Remove assorted dead paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 exploringBackwards = !next && (next != stop); 281 exploringBackwards = !next && (next != stop);
282 if (exploringBackwards) { 282 if (exploringBackwards) {
283 next = stop->previousInPreOrder(); 283 next = stop->previousInPreOrder();
284 continueExploring = next && !next->isRenderView(); 284 continueExploring = next && !next->isRenderView();
285 } 285 }
286 } 286 }
287 287
288 return next; 288 return next;
289 } 289 }
290 290
291 void RenderView::setSelection(RenderObject* start, int startPos, RenderObject* e nd, int endPos, SelectionPaintInvalidationMode blockPaintInvalidationMode) 291 void RenderView::setSelection(RenderObject* start, int startPos, RenderObject* e nd, int endPos)
292 { 292 {
293 // This code makes no assumptions as to if the rendering tree is up to date or not 293 // This code makes no assumptions as to if the rendering tree is up to date or not
294 // and will not try to update it. Currently clearSelection calls this 294 // and will not try to update it. Currently clearSelection calls this
295 // (intentionally) without updating the rendering tree as it doesn't care. 295 // (intentionally) without updating the rendering tree as it doesn't care.
296 // Other callers may want to force recalc style before calling this. 296 // Other callers may want to force recalc style before calling this.
297 297
298 // Make sure both our start and end objects are defined. 298 // Make sure both our start and end objects are defined.
299 // Check www.msnbc.com and try clicking around to find the case where this h appened. 299 // Check www.msnbc.com and try clicking around to find the case where this h appened.
300 if ((start && !end) || (end && !start)) 300 if ((start && !end) || (end && !start))
301 return; 301 return;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 void RenderView::getSelection(RenderObject*& startRenderer, int& startOffset, Re nderObject*& endRenderer, int& endOffset) const 346 void RenderView::getSelection(RenderObject*& startRenderer, int& startOffset, Re nderObject*& endRenderer, int& endOffset) const
347 { 347 {
348 startRenderer = m_selectionStart; 348 startRenderer = m_selectionStart;
349 startOffset = m_selectionStartPos; 349 startOffset = m_selectionStartPos;
350 endRenderer = m_selectionEnd; 350 endRenderer = m_selectionEnd;
351 endOffset = m_selectionEndPos; 351 endOffset = m_selectionEndPos;
352 } 352 }
353 353
354 void RenderView::clearSelection() 354 void RenderView::clearSelection()
355 { 355 {
356 setSelection(0, -1, 0, -1, PaintInvalidationNewMinusOld); 356 setSelection(0, -1, 0, -1);
357 } 357 }
358 358
359 void RenderView::selectionStartEnd(int& startPos, int& endPos) const 359 void RenderView::selectionStartEnd(int& startPos, int& endPos) const
360 { 360 {
361 startPos = m_selectionStartPos; 361 startPos = m_selectionStartPos;
362 endPos = m_selectionEndPos; 362 endPos = m_selectionEndPos;
363 } 363 }
364 364
365 LayoutRect RenderView::viewRect() const 365 LayoutRect RenderView::viewRect() const
366 { 366 {
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 m_iframes.remove(iframe); 481 m_iframes.remove(iframe);
482 } 482 }
483 483
484 void RenderView::updateIFramesAfterLayout() 484 void RenderView::updateIFramesAfterLayout()
485 { 485 {
486 for (auto& iframe: m_iframes) 486 for (auto& iframe: m_iframes)
487 iframe->updateWidgetBounds(); 487 iframe->updateWidgetBounds();
488 } 488 }
489 489
490 } // namespace blink 490 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698