Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: sky/engine/core/rendering/RenderObjectChildList.cpp

Issue 850763007: Delete canInvalidatePaintDuringPerformLayout. (Closed) Base URL: git@github.com:domokit/mojo.git@PaintInvalidationState
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderObjectChildList.cpp
diff --git a/sky/engine/core/rendering/RenderObjectChildList.cpp b/sky/engine/core/rendering/RenderObjectChildList.cpp
index f0dc8cd004011ae1ad2167fd450531456e187cdc..066f7c7f034441662e3ceac2e747b334895b2f5d 100644
--- a/sky/engine/core/rendering/RenderObjectChildList.cpp
+++ b/sky/engine/core/rendering/RenderObjectChildList.cpp
@@ -51,16 +51,11 @@ RenderObject* RenderObjectChildList::removeChildNode(RenderObject* owner, Render
if (oldChild->isFloatingOrOutOfFlowPositioned())
toRenderBox(oldChild)->removeFloatingOrPositionedChildFromBlockLists();
- {
- // FIXME: We should not be allowing paint invalidation during layout. crbug.com/336250
- AllowPaintInvalidationScope scoper(owner->frameView());
-
- // So that we'll get the appropriate dirty bit set (either that a normal flow child got yanked or
- // that a positioned child got yanked). We also issue paint invalidations, so that the area exposed when the child
- // disappears gets paint invalidated properly.
- if (!owner->documentBeingDestroyed() && notifyRenderer && oldChild->everHadLayout())
- oldChild->setNeedsLayoutAndPrefWidthsRecalc();
- }
+ // So that we'll get the appropriate dirty bit set (either that a normal flow child got yanked or
+ // that a positioned child got yanked). We also issue paint invalidations, so that the area exposed when the child
+ // disappears gets paint invalidated properly.
+ if (!owner->documentBeingDestroyed() && notifyRenderer && oldChild->everHadLayout())
+ oldChild->setNeedsLayoutAndPrefWidthsRecalc();
// If we have a line box wrapper, delete it.
if (oldChild->isBox())
« no previous file with comments | « sky/engine/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698