Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: sky/engine/core/frame/FrameView.h

Issue 850763007: Delete canInvalidatePaintDuringPerformLayout. (Closed) Base URL: git@github.com:domokit/mojo.git@PaintInvalidationState
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.h
diff --git a/sky/engine/core/frame/FrameView.h b/sky/engine/core/frame/FrameView.h
index 907ccde5f293aad389719c022591af338a1e4abd..732884dd98e65b90769ecdcb88d9dd5dc130f23e 100644
--- a/sky/engine/core/frame/FrameView.h
+++ b/sky/engine/core/frame/FrameView.h
@@ -81,9 +81,6 @@ public:
bool layoutPending() const;
bool isInPerformLayout() const;
- void setCanInvalidatePaintDuringPerformLayout(bool b) { m_canInvalidatePaintDuringPerformLayout = b; }
- bool canInvalidatePaintDuringPerformLayout() const { return m_canInvalidatePaintDuringPerformLayout; }
-
RenderObject* layoutRoot(bool onlyDuringLayout = false) const;
void clearLayoutSubtreeRoot() { m_layoutSubtreeRoot = 0; }
int layoutCount() const { return m_layoutCount; }
@@ -227,11 +224,6 @@ private:
void setLayoutSizeInternal(const IntSize&);
- bool paintInvalidationIsAllowed() const
- {
- return !isInPerformLayout() || canInvalidatePaintDuringPerformLayout();
- }
-
static double s_currentFrameTimeStamp; // used for detecting decoded resource thrash in the cache
static bool s_inPaintContents;
@@ -244,7 +236,6 @@ private:
bool m_layoutSchedulingEnabled;
bool m_inPerformLayout;
- bool m_canInvalidatePaintDuringPerformLayout;
bool m_inSynchronousPostLayout;
int m_layoutCount;
unsigned m_nestedLayoutCount;
@@ -284,30 +275,6 @@ private:
DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFrameView());
-class AllowPaintInvalidationScope {
-public:
- explicit AllowPaintInvalidationScope(FrameView* view)
- : m_view(view)
- , m_originalValue(view ? view->canInvalidatePaintDuringPerformLayout() : false)
- {
- if (!m_view)
- return;
-
- m_view->setCanInvalidatePaintDuringPerformLayout(true);
- }
-
- ~AllowPaintInvalidationScope()
- {
- if (!m_view)
- return;
-
- m_view->setCanInvalidatePaintDuringPerformLayout(m_originalValue);
- }
-private:
- FrameView* m_view;
- bool m_originalValue;
-};
-
} // namespace blink
#endif // SKY_ENGINE_CORE_FRAME_FRAMEVIEW_H_
« no previous file with comments | « no previous file | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698