Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 850753002: Fix prefetch-purpose layout test to support caching (Closed)

Created:
5 years, 11 months ago by jkarlin
Modified:
5 years, 10 months ago
Reviewers:
gavinp
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix prefetch-purpose layout test to support caching Prefetching behavior was recently changed to skip validation on the first reuse of a prefetched resource within 5 minutes. This broke the prefetch-purpose test because the test relied on the "cache-control: no-cache" of the prefetched resource forcing a revalidation. This CL changes the test to expect that the second request will be served from cache. BUG=448274 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189653

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/prefetch-purpose-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/misc/resources/prefetch-purpose.php View 1 chunk +9 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jkarlin
Thanks!
5 years, 11 months ago (2015-01-13 16:22:25 UTC) #2
jkarlin
On 2015/01/13 16:22:25, jkarlin wrote: > Thanks! PTAL Gavin. Thanks!
5 years, 11 months ago (2015-01-14 12:15:44 UTC) #3
jkarlin
On 2015/01/14 12:15:44, jkarlin wrote: > On 2015/01/13 16:22:25, jkarlin wrote: > > Thanks! > ...
5 years, 11 months ago (2015-01-15 11:46:29 UTC) #4
jkarlin
On 2015/01/15 11:46:29, jkarlin wrote: > On 2015/01/14 12:15:44, jkarlin wrote: > > On 2015/01/13 ...
5 years, 10 months ago (2015-01-29 12:10:39 UTC) #5
gavinp
On 2015/01/29 12:10:39, jkarlin wrote: > On 2015/01/15 11:46:29, jkarlin wrote: > > On 2015/01/14 ...
5 years, 10 months ago (2015-01-30 15:46:58 UTC) #6
jkarlin
On 2015/01/30 15:46:58, gavinp wrote: > On 2015/01/29 12:10:39, jkarlin wrote: > > On 2015/01/15 ...
5 years, 10 months ago (2015-01-30 15:55:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850753002/40001
5 years, 10 months ago (2015-02-06 15:54:35 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 17:12:08 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189653

Powered by Google App Engine
This is Rietveld 408576698