Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 850733004: MIPS: [turbofan] Improve code generation for unordered comparisons. (Closed)

Created:
5 years, 11 months ago by balazs.kilvady
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Improve code generation for unordered comparisons. Port c24220c0c14b60e6c6d7383b7d9c287086050afb TEST=cctest,unittests BUG= Committed: https://crrev.com/3da5a729e83a8bf1e6ef308f1e24f43931fa1772 Cr-Commit-Position: refs/heads/master@{#26045}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix switch cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -366 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 7 chunks +79 lines, -126 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 8 chunks +82 lines, -218 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
balazs.kilvady
5 years, 11 months ago (2015-01-13 17:02:40 UTC) #2
paul.l...
https://codereview.chromium.org/850733004/diff/1/src/compiler/mips/code-generator-mips.cc File src/compiler/mips/code-generator-mips.cc (right): https://codereview.chromium.org/850733004/diff/1/src/compiler/mips/code-generator-mips.cc#newcode211 src/compiler/mips/code-generator-mips.cc:211: break; Please remove the unnecessary break's after the return ...
5 years, 11 months ago (2015-01-13 17:34:57 UTC) #3
balazs.kilvady
https://codereview.chromium.org/850733004/diff/1/src/compiler/mips/code-generator-mips.cc File src/compiler/mips/code-generator-mips.cc (right): https://codereview.chromium.org/850733004/diff/1/src/compiler/mips/code-generator-mips.cc#newcode211 src/compiler/mips/code-generator-mips.cc:211: break; On 2015/01/13 17:34:57, paul.l... wrote: > Please remove ...
5 years, 11 months ago (2015-01-13 18:23:40 UTC) #4
paul.l...
LGTM.
5 years, 11 months ago (2015-01-13 18:41:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850733004/20001
5 years, 11 months ago (2015-01-13 18:42:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 20:28:04 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 20:28:28 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3da5a729e83a8bf1e6ef308f1e24f43931fa1772
Cr-Commit-Position: refs/heads/master@{#26045}

Powered by Google App Engine
This is Rietveld 408576698