Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 850703002: [New Multicolumn] Margins incorrectly accounted for before forced breaks. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Margins incorrectly accounted for before forced breaks. The spec basically says that margins should be ignored at column boundaries, although it's explicitly ambiguous about what should happen to top margins after a forced break. This CL is solely about margins before a break, though, and they should all be set to 0, so that contents that follow start at the top of the next column, instead of leaving one column blank and skipping to the next one after that. BUG=448366 R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
A LayoutTests/fast/multicol/margin-bottom-and-break-after.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/margin-bottom-and-break-after-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-13 13:22:24 UTC) #1
Julien - ping for review
lgtm
5 years, 11 months ago (2015-01-15 09:43:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850703002/1
5 years, 11 months ago (2015-01-15 09:43:57 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 09:47:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188456

Powered by Google App Engine
This is Rietveld 408576698