Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 850683003: Add DumpAccessibilityTree tests (19 of 20) (Closed)

Created:
5 years, 11 months ago by shreeramk
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (19 of 20) Also, exposing audio and video as GroupRole. BUG=170591 Committed: https://crrev.com/9a80b49fe9444892c9d89dcadf5c15bef997b0b3 Cr-Commit-Position: refs/heads/master@{#311694}

Patch Set 1 #

Patch Set 2 : uploading expectations #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -55 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 9 chunks +36 lines, -8 lines 0 comments Download
M content/test/data/accessibility/aria/aria-definition.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-labelledby-heading.html View 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria/aria-menuitem.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-menuitem-expected-android.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-menuitem-expected-mac.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
A content/test/data/accessibility/aria/aria-menuitem-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-navigation.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-progressbar.html View 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-rowheader.html View 1 chunk +9 lines, -6 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-rowheader-expected-android.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-rowheader-expected-mac.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
A content/test/data/accessibility/aria/aria-rowheader-expected-win.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-valuetext.html View 2 chunks +1 line, -3 lines 0 comments Download
A content/test/data/accessibility/aria/aria-valuetext-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-valuetext-expected-mac.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + content/test/data/accessibility/aria/aria-valuetext-expected-win.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/button.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/em.html View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/html/html.html View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/html/html-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/html-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/html-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/test/data/accessibility/html/iframe-coordinates.html View 2 chunks +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-button.html View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/html/input-email.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/html/input-email-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/html/input-email-expected-mac.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/input-email-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-search.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-types.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/meter.html View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/html/strong.html View 1 chunk +1 line, -2 lines 0 comments Download
A + content/test/data/accessibility/html/strong-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/html/strong-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/strong-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/test/data/accessibility/html/tab.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/table-simple.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/table-spans.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/transition.html View 2 chunks +1 line, -1 line 0 comments Download
A content/test/data/accessibility/html/video.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/video-expected-android.txt View 1 1 chunk +6 lines, -4 lines 0 comments Download
A + content/test/data/accessibility/html/video-expected-mac.txt View 1 1 chunk +1 line, -1 line 2 comments Download
A + content/test/data/accessibility/html/video-expected-win.txt View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
shreeramk
Please review. Thanks!
5 years, 11 months ago (2015-01-14 10:02:44 UTC) #2
dmazzoni
All those toolbars inside <audio> and <video> don't look right. Can you look into those? ...
5 years, 11 months ago (2015-01-14 17:54:27 UTC) #3
shreeramk
PTAL. Audio.html is already skipped. https://codereview.chromium.org/850683003/diff/60001/content/test/data/accessibility/html/video-expected-mac.txt File content/test/data/accessibility/html/video-expected-mac.txt (right): https://codereview.chromium.org/850683003/diff/60001/content/test/data/accessibility/html/video-expected-mac.txt#newcode5 content/test/data/accessibility/html/video-expected-mac.txt:5: AXToolbar AXTitle='media control' On ...
5 years, 11 months ago (2015-01-14 19:04:11 UTC) #4
dmazzoni
lgtm Got it, thanks.
5 years, 11 months ago (2015-01-14 19:28:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850683003/60001
5 years, 11 months ago (2015-01-15 02:40:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/37799)
5 years, 11 months ago (2015-01-15 03:36:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850683003/60001
5 years, 11 months ago (2015-01-15 03:55:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/37799)
5 years, 11 months ago (2015-01-15 03:55:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850683003/60001
5 years, 11 months ago (2015-01-15 17:58:39 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-15 18:16:43 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 18:17:33 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9a80b49fe9444892c9d89dcadf5c15bef997b0b3
Cr-Commit-Position: refs/heads/master@{#311694}

Powered by Google App Engine
This is Rietveld 408576698