Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 85063002: Add OnCompositionChanged and OnTextCommitted to RemoteInputMethodPrivateWin (Closed)

Created:
7 years ago by yukawa
Modified:
7 years ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add OnCompositionChanged and OnTextCommitted to RemoteInputMethodPrivateWin This CL adds two new methods OnCompositionChanged and OnTextCommitted to RemoteInputMethodPrivateWin so that corresponding events occurred in the metro_driver process can be forwarded to RemoteInputMethodWin. These new methods will work as real handlelrs of MetroViewerHostMsg_ImeCompositionChanged and MetroViewerHostMsg_ImeTextCommitted messages. In my first design, MetroViewerHostMsg_ImeCompositionChanged and MetroViewerHostMsg_ImeTextCommitted are directly handled in aura::RemoteRootWindowHostWin. However I changed my mind because how these IPC messages should be handled is a kind of implementation details of which only metro_driver::TextService implementation and ui::RemoteInputMethodWin should take care. This is why I moved these IPC handler from aura::RemoteRootWindowHostWin in ui::RemoteInputMethodPrivateWin. BUG=164964 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237047

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -4 lines) Patch
M ui/base/ime/remote_input_method_win.h View 4 chunks +21 lines, -1 line 0 comments Download
M ui/base/ime/remote_input_method_win.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M ui/base/ime/remote_input_method_win_unittest.cc View 5 chunks +106 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yukawa
Hi, This CL is a subset of differences between https://codereview.chromium.org/83233002/ patch set #1 and #2. ...
7 years ago (2013-11-25 04:40:42 UTC) #1
yukawa
Oh, nona-san seems to be on vacation. Komatsu-san, could you take a look?
7 years ago (2013-11-25 06:39:22 UTC) #2
Hiro Komatsu
lgtm
7 years ago (2013-11-25 06:50:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/85063002/50001
7 years ago (2013-11-25 06:54:34 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-25 08:41:24 UTC) #5
Message was sent while issue was closed.
Change committed as 237047

Powered by Google App Engine
This is Rietveld 408576698